Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper error handling and reporting to the API for the worker #124

Open
greenw0lf opened this issue Oct 10, 2024 · 2 comments · May be fixed by #201
Open

Proper error handling and reporting to the API for the worker #124

greenw0lf opened this issue Oct 10, 2024 · 2 comments · May be fixed by #201
Assignees
@greenw0lf

Comments

@greenw0lf
Copy link
Collaborator

greenw0lf commented Oct 10, 2024 •
edited
Loading

The solution we have right now for reporting is hacky, and the error handling doesn't handle all (or at least most) cases. I want to have an in-depth look at the code and see how to better report and handle all kinds of errors
@greenw0lf greenw0lf self-assigned this Oct 10, 2024
@greenw0lf
Copy link
Collaborator Author

Implemented this properly in the audio extraction repo: https://github.com/beeldengeluid/audio-extraction-worker

Follow the same example, but after I am done with the audio extraction work, so that no effort is put on code that will be removed from this worker (transcoding).

@greenw0lf
Copy link
Collaborator Author

I will also do some changes linked to #195 (the full provenance is logged, when it should be only for debug purposes)

@greenw0lf greenw0lf linked a pull request Jan 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greenw0lf greenw0lf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Huge refactor of code beeldengeluid/whisper-asr-worker
1 participant
@greenw0lf