Huge refactor of code #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latest version includes the logging I added of the audio duration and how much audio the VAD removes
Veldhoen
requested changes
Jan 24, 2025
| task.status = Status.DONE | ||
| task.response = outputs | ||
| logger.info(f"Successfully transcribed task {task.id}") | ||
| except Exception as e: |
There was a problem hiding this comment.
It would be nice to catch specific errors you know may occur, although it does make sense to catch a general 'Exception' at the end.
There was a problem hiding this comment.
Yes. My reasoning was that, this way, I catch any type of exception that could be thrown and I don't think the type matters too much since the exception itself will also be logged.
|
NB I merely looked at the code. Do you also have a test plan in mind? |
|
I have no test plan at the moment for this PR. Only tested locally using Docker and it was working as expected. If you also mean to create a suite of unit tests, I unfortunately won't have time for that this week and I won't be able to work on this further starting next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar refactor that was done to audio-extraction (see: beeldengeluid/audio-extraction-worker#28 and beeldengeluid/audio-extraction-worker#28 (comment)), mainly impacting exception raising and logging (no transcripts/provenance outputted as INFO, but as DEBUG now). Additionally, running the worker as a job was removed because it is tested and deployed as a service first and foremost.
Closes #124