Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added time to log messages #199

Merged
merged 4 commits into from
Jan 16, 2025
Merged

added time to log messages #199

merged 4 commits into from
Jan 16, 2025

Conversation

wmelder
Copy link
Contributor

@wmelder wmelder commented Jan 9, 2025

No description provided.

@wmelder wmelder requested a review from Veldhoen January 9, 2025 15:03
@wmelder wmelder linked an issue Jan 9, 2025 that may be closed by this pull request
add standard log format to whisper_api #198
Closed
Veldhoen
Veldhoen approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@Veldhoen Veldhoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the fix is adequate, just think it would make sense to add it to all the modules!

@greenw0lf
Copy link
Collaborator

@wmelder I'll pick up this issue and make sure the log format is consistent all across the worker

@greenw0lf greenw0lf merged commit 5dc6720 into main Jan 16, 2025
1 check passed
@greenw0lf greenw0lf deleted the 198-add-standard-log-format-to-whisper_api branch January 16, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veldhoen Veldhoen Veldhoen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add standard log format to whisper_api
3 participants
@wmelder @greenw0lf @Veldhoen