194 graceful fail #203
Open
194 graceful fail #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shutdown event blocks all incoming requests, therefore we cannot wait for a get request for the current task to be received first before shutting down the app. So, the alternative for now is to at least let the current task finish, then program something in the Airflow triggerer that checks in S3 whether a specific program has been transcribed already or not.
|
How would you suggest to test this? |
It is expected that the worker will stay alive until the process is done, then shut down completely. Unfortunately, it doesn't work via Docker, but Govert recommended that I test locally anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If either one of you @Veldhoen or @gb-beng can have a look at this, that'd be great!
Closes #194