Skip to content

Fix: Spotify plugin unable to find Chinese/Japanese albums #5703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

semohr
Copy link
Contributor

@semohr semohr commented Apr 3, 2025

Description

Removing the unicode.unidecode as it is not required for url param encoding. Maybe the spotify api changed throughout the years 🤷

close #5699

Tested the fix locally and the matches seem better:

(venv) (base) sebastian:/mnt/Repositories/beets$ beet import ./裘盛戎\ -\ 盗御马/ -t 
  Match (89.7%):
  裘盛戎 - 盗御马
  ≠ source, tracks
  Spotify, None, 2023, None, China Recording Group Co., Ltd, None, None
  https://open.spotify.com/album/6OoLtNfZXRCYJT0LKnG94P
  * Artist: 裘盛戎
  * Album: 盗御马
     * (#1) 盗御马(一) (3:02)
     * (#2) 盗御马(二) (3:21)
➜ [A]pply, More candidates, Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates? B

vs old

(venv) (base) sebastian:/mnt/Repositories/beets$ beet import ./裘盛戎\ -\ 盗御马/ -t 
Finding tags for album "裘盛戎 - 盗御马".
  Candidates:
  1. (37.9%) 小倉唯 with ぷるぷるいゃ〜ん - 盗んだハートはココですよ?
             ≠ artist, album, tracks, ...
             MusicBrainz, Digital Media, 2010, JP, UP‐FRONT WORKS, None, None
  2. (33.2%) 裘德 - 荔枝
             ≠ album, tracks, artist, ...
             MusicBrainz, Digital Media, 2022, XW, 杭州网易云音乐科技有限公司, None, None
  3. (28.2%) 戎きあら - 君がいない世界に
             ≠ album, artist, tracks, ...
             MusicBrainz, CD, 2024, JP, BAKKY RECORDS, BAKKY-204, None
  4. (18.6%) 裘盛戎, 高盛麟 & 萧长华 - Zhōng guó xì qǔ míng jiā míng xì jīng jù: Luò mǎ hú (xuǎn chǎng) Lián huán tào (xuǎn chǎng)
             ≠ album, missing tracks, tracks, ...
             MusicBrainz, 2xCD, 2005, CN, 北京中唱时代音像出版有限公司, ACD-097, None
  5. (18.2%) 裘盛戎, 高盛麟 & 萧长华 - 中国戏曲名家名戏 京剧:落马湖(选场) 连环套(选场)
             ≠ album, missing tracks, tracks, ...
             MusicBrainz, 2xCD, 2005, CN, 北京中唱时代音像出版有限公司, ACD-097, None
➜ # selection (default 1), Skip, Use as-is, as Tracks, Group albums,
Enter search, enter Id, aBort, eDit, edit Candidates? B
  • Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)

@semohr
Copy link
Contributor Author

semohr commented May 19, 2025

see #5705

@semohr semohr closed this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotify plugin unable to find Chinese/Japanese albums
1 participant