Refactor of metadata plugin and opt in all metadata plugins to new baseclass. #5764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
semohr
force-pushed
the
metadatasource-cleanup
branch
2 times, most recently
from
ce82a20 to
dc93afc
Compare
semohr
changed the base branch from
make-musicbrainz-a-plugin
to
restructure-id-extractors
This will make it easier to track changes in later commits.
snejus
force-pushed
the
restructure-id-extractors
branch
2 times, most recently
from
a231e4d to
c51da3f
Compare
snejus
force-pushed
the
restructure-id-extractors
branch
from
c51da3f to
fb0d14e
Compare
snejus
force-pushed
the
restructure-id-extractors
branch
from
fb0d14e to
409f3ab
Compare
snejus
force-pushed
the
restructure-id-extractors
branch
from
409f3ab to
ad0a784
Compare
…o metadatasource-cleanup
snejus
force-pushed
the
restructure-id-extractors
branch
from
ad0a784 to
2ee5de4
Compare
semohr
changed the base branch from
restructure-id-extractors
to
make-musicbrainz-a-plugin
snejus
force-pushed
the
make-musicbrainz-a-plugin
branch
3 times, most recently
from
edf688f to
f1dc75f
Compare
|
Well I don't think we can reopen this as the source branch is deleted now. I guess I create another PR for this :) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment the
MetaDataSourcePluginhas multiple responsibilities:_searchapiI propose splitting these responsibilities, as it would enable us to use the
MetaDataSourcePluginbaseclass with plugins that use external packages to fetch data.This follows from discussion in #5761 and #5748 (comment).
Feedback is highly appreciated, as this is mainly architectural decision and I would prefer if the new behavior is a shared consensus.
To Do
MetaDataSourcePlugin