Make modulizable in g++. #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I'm trying to compile
beman/executionintoC++20 Modules:while g++ complains about one
exposes TU-local entity:in
beman/execution/detail/completion_domain.hpp.When we look into
completion_domain.hpp, heregetis a function-local lambda with local captures (that is to say, is TU-local)module-exportableafter P1815. Here, the templates ofusing type = ...; return std::conditional<...type...>;are infected as TU-local.So I made a tiny change on
getfunction, making itconstexprandexportable.Thank you! This is an amazing library (super tidy!!) and I'll star it.