Skip to content

Use testing container #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wusatosi wants to merge 14 commits into from
Closed

Use testing container #168

wusatosi wants to merge 14 commits into from

Conversation

@wusatosi
Copy link
Member

@wusatosi wusatosi commented May 31, 2025 •
edited
Loading

Description

Adopts the new testing container in CI with some refactoring.

This should fix the issue described here: #167 (comment)

Testing

CI passing.

Meta

  • If all approvals are obtained and the PR is green, any Beman member can merge the PR.

@wusatosi wusatosi requested a review from a team May 31, 2025 18:07
@wusatosi wusatosi mentioned this pull request May 31, 2025
Closed
JeffGarland
JeffGarland reviewed Jun 1, 2025
View reviewed changes
nickelpro
nickelpro approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@nickelpro nickelpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does the correct thing and the approach is reasonable.

@nickelpro
Copy link
Member

nickelpro commented Jun 2, 2025

lmao I'm not an exemplar owner, so my review is advisory I guess

@wusatosi
Copy link
Member Author

wusatosi commented Jun 2, 2025 •
edited
Loading

Actually I am going to remove the cmake versioning inputs, because this produces inconsistent behavior between testing container and windows/ macos tests. In testing container the latest version of cmake and ninja is always pulled.

@wusatosi
Remove custom CMake and Ninja versioning
7d187f0 
This is so we can be consistent with testing container,
which always has the latest available CMake and Ninja.
@nickelpro
Copy link
Member

nickelpro commented Jun 2, 2025

It's a non-issue as the CMake behavior is dictated by what the cmake_minimum_version is set to, and Ninja doesn't change interfaces almost ever.

My review is only to say, "yep we're running on the right compiler versions now".

So ya, the CMake/Ninja stuff is whatever works.

@nickelpro nickelpro mentioned this pull request Jun 4, 2025
Closed
1 task
@camio
Copy link
Member

camio commented Jul 18, 2025

@ednolan, is this PR still relevant given the CI changes you made recently?

@ednolan
Copy link
Member

ednolan commented Jul 18, 2025

No, it's been superseded.

@ednolan ednolan closed this Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeffGarland JeffGarland JeffGarland left review comments

@nickelpro nickelpro nickelpro approved these changes

@bretbrownjr bretbrownjr Awaiting requested review from bretbrownjr bretbrownjr is a code owner

@camio camio Awaiting requested review from camio camio is a code owner

@dietmarkuehl dietmarkuehl Awaiting requested review from dietmarkuehl dietmarkuehl is a code owner

@neatudarius neatudarius Awaiting requested review from neatudarius neatudarius is a code owner

@steve-downey steve-downey Awaiting requested review from steve-downey steve-downey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wusatosi @nickelpro @camio @ednolan @JeffGarland