Rename Optional26 to Optional #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the target ship date from the name of the project.
Member
|
Link this PR to bemanproject/beman#85 |
neatudarius
approved these changes
Jan 20, 2025
Member
|
@steve-downey , can we merge this please? (if no harm to other urgent PRs) We would like to advance with bemanproject/beman#85. |
Member
|
FYI. I renamed the repo. CC: @steve-downey |
Member
Author
|
You'll also need to fix the coveralls CI, I think?
…On Tue, Jan 21, 2025, 08:11 Darius Neațu ***@***.***> wrote:
FYI. I renamed the repo. CC: @steve-downey
<https://github.com/steve-downey>
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5QFOJTY73KLVHO6RT32LZBRFAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGY4TMMZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
I'll add to my list. Can you point to the place where I should check it? |
Member
Author
|
… On Tue, Jan 21, 2025, 08:21 Darius Neațu ***@***.***> wrote:
You'll also need to fix the coveralls CI, I think?
… <#m_4281091708513815519_>
On Tue, Jan 21, 2025, 08:11 Darius Neațu *@*.*> wrote: FYI. I renamed the
repo. CC: @steve-downey <https://github.com/steve-downey>
https://github.com/steve-downey <https://github.com/steve-downey> — Reply
to this email directly, view it on GitHub <#102 (comment)
<#102 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAVNZ5QFOJTY73KLVHO6RT32LZBRFAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGY4TMMZQGI
<https://github.com/notifications/unsubscribe-auth/AAVNZ5QFOJTY73KLVHO6RT32LZBRFAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUGY4TMMZQGI>
. You are receiving this because you were mentioned.Message ID: @.*>
I'll add to my list. Can you point to the place where I should check it?
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5UJ6YTC6ACEOYN2KJT2LZCWNAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUG4ZDCMJRGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Missed that. I was under the impression that ci.yaml was completely updated in your PR. #104 here is the fix. |
Member
Author
|
The problem is that the repository name is external to the repo, except for
this where coveralls needs to find the file.
Figured this out because I haven't been constantly renaming my fork and
coveralls coverage has been broken there.
…On Tue, Jan 21, 2025, 08:50 Darius Neațu ***@***.***> wrote:
Missed that. I was under the impression that ci.yaml was completely
updated in your PR. #104
<#104> here is the fix.
—
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAVNZ5TFTVDPMCJSW4QHNBD2LZGCHAVCNFSM6AAAAABVN7E3RKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBUG44TCNJZGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the target ship date from the name of the project.