Fixes to optional #109
Merged
Fixes to optional #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to *(std::move(rhs)) from std::move(*rhs), fixing the value category of the return type to be controlled by the operator*() function. Remove the now unneeded specializations. Have the paper reflect the new implementation in new revision.
Run coverage locally the same way as it happens in CI.
Colon in places. Commas and and in Constraint lists.
Direct initialization with static_cast fails if a base converts to a derived, which can be legal. Construction adjusted to fix.
Edits from wording review
Change draft state. Internally rename back to P paper Change draft state.
neatudarius
approved these changes
Feb 18, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
LGTM 👍
Congrats again for optional ref got into C++26!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes underlying std::move problem
Changes a static_cast where there is a chance of undefined behavior.
Paper as presented in Hagenberg.