Skip to content

const West #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ednolan merged 1 commit into from
Nov 2, 2025
Merged

const West #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/readme_examples.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ bool windows_path() {
std::vector<int> path_as_ints = {U'C', U':', U'\x00010000'};
std::filesystem::path path =
path_as_ints | as_char32_t | std::ranges::to<std::u32string>();
auto const& native_path = path.native();
const auto& native_path = path.native();
if (native_path != std::wstring{L'C', L':', L'\xD800', L'\xDC00'}) {
return false;
}
Expand Down
6 changes: 3 additions & 3 deletions include/beman/utf_view/to_utf_view.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ struct exposition_only_to_utf_view_impl<V, OrError, ToType>::exposition_only_ite
}


constexpr std::ranges::iterator_t<exposition_only_Base> const& base() const& noexcept {
constexpr const std::ranges::iterator_t<exposition_only_Base>& base() const& noexcept {
return current_;
}

Expand Down Expand Up @@ -342,8 +342,8 @@ struct exposition_only_to_utf_view_impl<V, OrError, ToType>::exposition_only_ite
return retval;
}

friend constexpr bool operator==(exposition_only_iterator const& lhs,
exposition_only_iterator const& rhs)
friend constexpr bool operator==(const exposition_only_iterator& lhs,
const exposition_only_iterator& rhs)
requires std::equality_comparable<std::ranges::iterator_t<exposition_only_Base>>
{
if constexpr (std::ranges::forward_range<exposition_only_Base>) {
Expand Down
6 changes: 3 additions & 3 deletions paper/P2728.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,7 +706,7 @@ public:
@*read*@();
}

constexpr iterator_t<@*Base*@> const& base() const& noexcept { return current_; }
constexpr const iterator_t<@*Base*@>& base() const& noexcept { return current_; }

constexpr iterator_t<@*Base*@> base() && { return std::move(current_); }

Expand Down Expand Up @@ -756,7 +756,7 @@ public:
return retval;
}

friend constexpr bool operator==(@*iterator*@ const& lhs, @*iterator*@ const& rhs) requires equality_comparable<iterator_t<@*Base*@>>
friend constexpr bool operator==(const @*iterator*@& lhs, const @*iterator*@& rhs) requires equality_comparable<iterator_t<@*Base*@>>
{
if constexpr (forward_range<@*Base*@>) {
return lhs.base() == rhs.base() && lhs.buf_index_ == rhs.buf_index_;
Expand Down Expand Up @@ -1227,7 +1227,7 @@ expression `as_charN_t(E)` is expression-equivalent to:
```c++
std::vector<int> path_as_ints = {U'C', U':', U'\x00010000'};
std::filesystem::path path = path_as_ints | as_char32_t | std::ranges::to<std::u32string>();
auto const& native_path = path.native();
const auto& native_path = path.native();
if (native_path != std::wstring{L'C', L':', L'\xD800', L'\xDC00'}) {
return false;
}
Expand Down