Add CMake option controlling whether tests are built #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a UTF_VIEW_BUILD_TESTS CMake option. The logic around
its use is:
- If the user has explicitly set UTF_VIEW_BUILD_TESTS, BUILD_TESTING
is set to that value
- Otherwise, if BUILD_TESTING was already set to ON, then it continues
to be set to ON
- Otherwise, if this is the top-level CMake project and not a
dependency of another project, BUILD_TESTING is set to ON
- Otherwise, BUILD_TESTING is set to OFF
Using BUILD_TESTING to control whether tests are enabled is
recommended by CMake in its documentation here:
https://cmake.org/cmake/help/latest/module/CTest.html
This logic is based on a similar option implemented in NVIDIA/stdexec.
My commit implementing this logic can be found here:
NVIDIA/stdexec@ee0a962
Additional reasoning can be found here:
NVIDIA/stdexec#1380 (comment)
Pull Request Test Coverage Report for Build 11825407831Details
💛 - Coveralls |
Member
Author
|
This approach is not used in the Beman project because BUILD_TESTING doesn't provide sufficient granularity for large projects. This pull request will be superseded with an alternative that uses enable_testing(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a UTF_VIEW_BUILD_TESTS CMake option. The logic around its use is:
Using BUILD_TESTING to control whether tests are enabled is recommended by CMake in its documentation here:
https://cmake.org/cmake/help/latest/module/CTest.html
This logic is based on a similar option implemented in NVIDIA/stdexec. My commit implementing this logic can be found here:
NVIDIA/stdexec@ee0a962
Additional reasoning can be found here:
NVIDIA/stdexec#1380 (comment)