Add CMake option controlling whether tests are built #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11826402277Details
💛 - Coveralls |
camio
approved these changes
Nov 13, 2024
Member
camio
left a comment
camio
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise LGTM
CMakeLists.txt
Outdated
Comment on lines
23
to
25
| if (UTF_VIEW_BUILD_TESTING) | ||
| enable_testing() | ||
| endif() |
Member
There was a problem hiding this comment.
Suggested change
| if (UTF_VIEW_BUILD_TESTING) | |
| enable_testing() | |
| endif() |
|
|
||
| if(BUILD_TESTING) | ||
| if(UTF_VIEW_BUILD_TESTING) | ||
| add_subdirectory(tests/utf_view) |
Member
There was a problem hiding this comment.
Suggested change
| add_subdirectory(tests/utf_view) | |
| enable_testing() | |
| add_subdirectory(tests/utf_view) |
This commit eliminates our use of BUILD_TESTING and adds a project-specific UTF_VIEW_BUILD_TESTING CMake option. It avoids including CTest and relies on calls to enable_testing(), which is what Beman repositories do to ensure sufficient granularity.
ednolan
force-pushed
the
test_build_option2
branch
from
d64b274 to
fd6f756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eliminates our use of BUILD_TESTING and adds a project-specific UTF_VIEW_BUILD_TESTING CMake option. It avoids including CTest and relies on calls to enable_testing(), which is what Beman repositories do to ensure sufficient granularity.