Skip to content

Conversation

@ednolan
Copy link
Member

@ednolan ednolan commented Mar 18, 2025

Previously, the GCC 14 preset CI job used my own Docker image; this commit makes it use the new bemanproject/testing-images image instead, while the job that produces the coverage report and the builds the paper html still uses my own image for now since that image contains additional tools preinstalled via apt.

Previously, the GCC 14 preset CI job used my own Docker image; this
commit makes it use the new bemanproject/testing-images image instead,
while the job that produces the coverage report and the builds the
paper html still uses my own image for now since that image contains
additional tools preinstalled via apt.
@ednolan ednolan requested review from a team and RaduNichita March 18, 2025 15:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13927567441

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 13888797758: 0.0%
Covered Lines: 454
Relevant Lines: 454

💛 - Coveralls

@ednolan ednolan merged commit d93ff05 into main Mar 18, 2025
9 of 10 checks passed
@ednolan ednolan deleted the enolan_gcctestingimage1 branch March 18, 2025 16:10
@RaduNichita
Copy link
Contributor

RaduNichita commented Mar 18, 2025

Hi,

Sorry for bumping into this closed issue, but do we think we could use the same bemanproject/testing-image for the CI for other repositories (for example optional).

I've been trying to simplify the CI workflow (at least for Linux) and this seems like a good idea to look into.

cc: @ednolan @neatudarius

@ednolan
Copy link
Member Author

ednolan commented Mar 18, 2025

@RaduNichita, yes-- it's a work in progress, but @wusatosi has been making these images so they can be used for CI by all Beman repositories.

@wusatosi
Copy link
Member

wusatosi commented Mar 18, 2025

@RaduNichita I will come work on this after I am done with current work with vcpkg. We don't have sufficient infrastructure to maintain these images yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants