Skip to content

Update pull_request_template.md to match exemplar #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ednolan merged 1 commit into from
Jul 14, 2025
Merged

Update pull_request_template.md to match exemplar #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 3 additions & 69 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,71 +1,5 @@
<!--
Please follow our code of conduct when engaging in the Beman community:
https://github.com/bemanproject/beman/blob/main/docs/CODE_OF_CONDUCT.md
Please take note of the following when contributing:
- Our code of conduct: https://github.com/bemanproject/beman/blob/main/docs/CODE_OF_CONDUCT.md
- The Beman Standard: https://github.com/bemanproject/beman/blob/main/docs/BEMAN_STANDARD.md
-->

<!--
Thank you for your contribution!

If you are updating project structure or build configs:
- Make sure your contribution conforms to the Beman Standard:
https://github.com/bemanproject/beman/blob/main/docs/BEMAN_STANDARD.md
- For new CMake arguments / presets: please make sure you added appropriate CI tests.

If you are updating documentation:
- Make sure badges and pictures does not impact readability.

If you are updating implementations:
- Make sure you submit appropriate testing.

We encourage small and incremental additions instead of large redesigns.
They are easier and faster to review.
They are also less likely to introduce bugs.

While we do not formally adopt this guide as a standard,
we encourage you to read and consider:
"The CL author’s guide to getting through code review".
https://google.github.io/eng-practices/review/developer/

Regardless, feel free to open a PR on your existing changes.
We appreciate the suggestion and will help out.

Please run pre-commit against your change to comply with our linting rules.
The command to check all files in the directory is:
$ pre-commit run --all-files
-->

<!-- markdownlint-disable-next-line MD041 -->
## Description

Please describe your contribution in a single sentence.

## Related Issues

<!-- use magic keywords like "fix" to close issues linked to this PR automatically -->

## Motivation and Context

Explain why this change is needed.

## Testing

Explain how is this tested.

## Meta

<!--
The convention in Beman is for the PR author to merge the PR once it's ready.
You can check this box to indicate that you would like Beman members to merge the PR
for you when appropriate reviews have passed.

Please note that:
1. Stale PR may still be merged by a Beman member,
if you need significant time to work on your PR,
leave a comment and change it's status to draft.
2. If you are not a member of the Beman project,
you may not have the permission necessary to merge your own PR.
-->

- [ ] If all approvals are obtained and the PR is green, any Beman member can merge the PR.

<!-- make sure you run pre-commit before opening a PR -->