Replace std::uc namespace with std::ranges and std::views #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change was recommended by Tom Honermann.
jwakely
reviewed
Oct 3, 2025
| /* PAPER: template <class ToType, class V> */ | ||
| /* PAPER: inline constexpr bool enable_borrowed_range< */ | ||
| /* PAPER: std::uc::exposition_only_to_utf_view_impl<ToType, V>> = enable_borrowed_range<V>; */ | ||
| /* PAPER: std::exposition_only_to_utf_view_impl<ToType, V>> = enable_borrowed_range<V>; */ |
Collaborator
There was a problem hiding this comment.
Shouldn't this be std::ranges?
jwakely
reviewed
Oct 3, 2025
| /* PAPER: */ | ||
| /* PAPER: template <class V> */ | ||
| /* PAPER: inline constexpr bool enable_borrowed_range<std::uc::to_utf8_view<V>> = enable_borrowed_range<V>; */ | ||
| /* PAPER: inline constexpr bool enable_borrowed_range<std::to_utf8_view<V>> = enable_borrowed_range<V>; */ |
Member
Author
There was a problem hiding this comment.
Oops, thanks for catching these. It's now moot though, because in the latest revision these lines have been removed since the view is no longer borrowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was recommended by Tom Honermann.