Skip to content

fix(lockfile): regenerate to restore strict npm ci#20

Merged
ben-vargas merged 1 commit into
ben-vargas:ai-sdk-v5from
bjcoombs:fix-ci-npm-install
Apr 14, 2026
Merged

fix(lockfile): regenerate to restore strict npm ci#20
ben-vargas merged 1 commit into
ben-vargas:ai-sdk-v5from
bjcoombs:fix-ci-npm-install

Conversation

@bjcoombs
Copy link
Copy Markdown

@bjcoombs bjcoombs commented Apr 14, 2026

Problem

The CI workflow added in #19 fails on every push to `ai-sdk-v5` because `package-lock.json` is out-of-sync with `package.json`:

```
npm error Missing: @types/[email protected] from lock file
npm error Missing: [email protected] from lock file
```

Failing run on the #19 merge commit: https://github.com/ben-vargas/ai-sdk-provider-opencode-sdk/actions/runs/24408770528

The drift was present before CI landed - it just wasn't visible without CI.

Fix

Targeted lockfile update via `npm install --package-lock-only` to add the two missing transitive entries. 21-line addition, no other churn.

Chose this over loosening CI to `npm install` because:

  • Strict `npm ci` guarantees reproducible installs and catches future drift
  • Loosening CI just hides the same class of problem

Test plan

  • `npm ci` succeeds locally on node 20 / npm 10.8.2
  • CI passes on this PR (both zod 3 and zod 4 matrix jobs)

@types/[email protected] and [email protected] were already referenced
via the dep graph but missing from package-lock.json, causing strict
npm ci to fail on every run once CI landed (ben-vargas#19).

21-line targeted lockfile addition via `npm install --package-lock-only`
to bring the lockfile into sync without churning unrelated entries.
Keeps CI strict.
@bjcoombs bjcoombs force-pushed the fix-ci-npm-install branch from 4bd56e3 to e0b9b71 Compare April 14, 2026 15:57
@bjcoombs bjcoombs changed the title ci: use npm install so the new workflow passes fix(lockfile): regenerate to restore strict npm ci Apr 14, 2026
@ben-vargas ben-vargas merged commit c0d5db9 into ben-vargas:ai-sdk-v5 Apr 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants