Skip to content

fix(layout): repoint stale flat-path refs inside moved acp/ subtree (follow-up to #19) - #20

Merged
Yiminnn merged 1 commit into
mainfrom
fix/acp-subtree-stale-paths
Jun 27, 2026
Merged

fix(layout): repoint stale flat-path refs inside moved acp/ subtree (follow-up to #19)#20
Yiminnn merged 1 commit into
mainfrom
fix/acp-subtree-stale-paths

Conversation

@Yiminnn

@Yiminnn Yiminnn commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #19 (the acp/ reorg). Five flat-path references inside the moved acp/ subtree were not repointed by the reorg (its grep excluded acp/):

  • acp/mimo-acp/README.md + acp/mini-swe-acp/README.mdpip install …#subdirectory=<flat> (the documented install command was broken).
  • acp/mimo-acp/pyproject.toml, acp/mini-swe-acp/pyproject.toml, acp/mini-swe-code/pyproject.toml — dead tree/main/<flat>#readme Documentation URLs.

All repointed to acp/<dir>. No discovery/manifest/contract-suite impact (CI stayed green on #19 because link-check doesn't validate embedded pip/https URLs).

Follow-up to #19. The acp/ subtree's own pip-install subdirectory= commands and
pyproject Documentation URLs still pointed at the pre-move repo-root paths; repoint
them to acp/<dir>. No discovery/manifest impact (contract suite unaffected).
@Yiminnn
Yiminnn merged commit 9130e5f into main Jun 27, 2026
5 checks passed
@greptile-apps

greptile-apps Bot commented Jun 27, 2026

Copy link
Copy Markdown

Greptile Summary

This PR fixes five stale flat-path URLs left over from the acp/ directory reorganization in #19. The reorg script excluded acp/ from its grep, so references inside the moved subtree were missed.

  • acp/mimo-acp/README.md and acp/mini-swe-acp/README.md: pip install #subdirectory= arguments updated from the old flat paths (mimo-acp, mini-swe-acp) to the correct nested paths (acp/mimo-acp, acp/mini-swe-acp), restoring working install commands for users.
  • acp/mimo-acp/pyproject.toml, acp/mini-swe-acp/pyproject.toml, acp/mini-swe-code/pyproject.toml: Documentation URLs updated from tree/main/<flat> to tree/main/acp/<dir>, fixing dead links in PyPI metadata.

Confidence Score: 5/5

Safe to merge — all changes are targeted URL corrections with no logic, dependency, or schema impact.

Every change is a one-line string substitution replacing a broken flat-path reference with the correct nested path. A grep over the full repo confirms no remaining stale occurrences. No executable code, no configuration semantics, and no contract surfaces are touched.

No files require special attention.

Important Files Changed

Filename Overview
acp/mimo-acp/README.md Corrects pip install subdirectory URL from flat mimo-acp to acp/mimo-acp after directory reorg.
acp/mimo-acp/pyproject.toml Updates Documentation URL from stale tree/main/mimo-acp to correct tree/main/acp/mimo-acp.
acp/mini-swe-acp/README.md Corrects pip install subdirectory URL from flat mini-swe-acp to acp/mini-swe-acp after directory reorg.
acp/mini-swe-acp/pyproject.toml Updates Documentation URL from stale tree/main/mini-swe-acp to correct tree/main/acp/mini-swe-acp.
acp/mini-swe-code/pyproject.toml Updates Documentation URL from stale tree/main/mini-swe-code to correct tree/main/acp/mini-swe-code.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User runs pip install command] --> B{subdirectory path}
    B -- "Before PR (stale flat path)\ne.g. subdirectory=mimo-acp" --> C[❌ Git clone fails\nsubdirectory not found]
    B -- "After PR (correct path)\ne.g. subdirectory=acp/mimo-acp" --> D[✅ Git clone succeeds\nPackage installed]

    E[PyPI / pip show Documentation URL] --> F{tree/main path}
    F -- "Before PR\ntree/main/mimo-acp" --> G[❌ 404 Dead link]
    F -- "After PR\ntree/main/acp/mimo-acp" --> H[✅ Valid GitHub URL]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[User runs pip install command] --> B{subdirectory path}
    B -- "Before PR (stale flat path)\ne.g. subdirectory=mimo-acp" --> C[❌ Git clone fails\nsubdirectory not found]
    B -- "After PR (correct path)\ne.g. subdirectory=acp/mimo-acp" --> D[✅ Git clone succeeds\nPackage installed]

    E[PyPI / pip show Documentation URL] --> F{tree/main path}
    F -- "Before PR\ntree/main/mimo-acp" --> G[❌ 404 Dead link]
    F -- "After PR\ntree/main/acp/mimo-acp" --> H[✅ Valid GitHub URL]
Loading

Reviews (1): Last reviewed commit: "fix(layout): repoint stale flat-path ref..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant