fix(layout): repoint stale flat-path refs inside moved acp/ subtree (follow-up to #19) - #20
Merged
Merged
Conversation
Follow-up to #19. The acp/ subtree's own pip-install subdirectory= commands and pyproject Documentation URLs still pointed at the pre-move repo-root paths; repoint them to acp/<dir>. No discovery/manifest impact (contract suite unaffected).
Greptile SummaryThis PR fixes five stale flat-path URLs left over from the
Confidence Score: 5/5Safe to merge — all changes are targeted URL corrections with no logic, dependency, or schema impact. Every change is a one-line string substitution replacing a broken flat-path reference with the correct nested path. A grep over the full repo confirms no remaining stale occurrences. No executable code, no configuration semantics, and no contract surfaces are touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User runs pip install command] --> B{subdirectory path}
B -- "Before PR (stale flat path)\ne.g. subdirectory=mimo-acp" --> C[❌ Git clone fails\nsubdirectory not found]
B -- "After PR (correct path)\ne.g. subdirectory=acp/mimo-acp" --> D[✅ Git clone succeeds\nPackage installed]
E[PyPI / pip show Documentation URL] --> F{tree/main path}
F -- "Before PR\ntree/main/mimo-acp" --> G[❌ 404 Dead link]
F -- "After PR\ntree/main/acp/mimo-acp" --> H[✅ Valid GitHub URL]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User runs pip install command] --> B{subdirectory path}
B -- "Before PR (stale flat path)\ne.g. subdirectory=mimo-acp" --> C[❌ Git clone fails\nsubdirectory not found]
B -- "After PR (correct path)\ne.g. subdirectory=acp/mimo-acp" --> D[✅ Git clone succeeds\nPackage installed]
E[PyPI / pip show Documentation URL] --> F{tree/main path}
F -- "Before PR\ntree/main/mimo-acp" --> G[❌ 404 Dead link]
F -- "After PR\ntree/main/acp/mimo-acp" --> H[✅ Valid GitHub URL]
Reviews (1): Last reviewed commit: "fix(layout): repoint stale flat-path ref..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19 (the acp/ reorg). Five flat-path references inside the moved
acp/subtree were not repointed by the reorg (its grep excludedacp/):acp/mimo-acp/README.md+acp/mini-swe-acp/README.md—pip install …#subdirectory=<flat>(the documented install command was broken).acp/mimo-acp/pyproject.toml,acp/mini-swe-acp/pyproject.toml,acp/mini-swe-code/pyproject.toml— deadtree/main/<flat>#readmeDocumentation URLs.All repointed to
acp/<dir>. No discovery/manifest/contract-suite impact (CI stayed green on #19 because link-check doesn't validate embedded pip/https URLs).