Skip to content

Fix/encrypted ipc transport#280

Merged
adams813 merged 3 commits intobenelabs:mainfrom
MickeeJay:fix/encrypted-ipc-transport
May 3, 2026
Merged

Fix/encrypted ipc transport#280
adams813 merged 3 commits intobenelabs:mainfrom
MickeeJay:fix/encrypted-ipc-transport

Conversation

@MickeeJay
Copy link
Copy Markdown
Contributor

feat: Wire encrypted stdio IPC transport into server entry point — closes #72

Summary

The encrypted transport logic was partially implemented but never wired into
the main server entry point. Configuration schemas were also missing the
necessary key fields, and several lint and config errors blocked the code
from building or running correctly in CI. This PR completes the integration,
making encrypted stdio IPC fully operational when a key is provided.


Problem

Three gaps blocked the feature from being functional end-to-end:

  • src/index.ts did not conditionally select the encrypted transport factory
    when a key was present — the implementation existed but was never invoked
  • PULSAR_IPC_ENCRYPTION_KEY was absent from the configuration schema,
    so the key could not be read or validated at startup
  • Lint errors in the transport layer and test suite (constant conditions,
    stale globals) prevented clean builds and reliable CI runs

What Changed

1. Server entry point — encrypted transport wiring
Updated src/index.ts to use the encrypted transport factory when
PULSAR_IPC_ENCRYPTION_KEY is present, falling back to the standard
transport when no key is configured.

2. Configuration — PULSAR_IPC_ENCRYPTION_KEY
Added the key to the configuration schema with:

  • Proper log redaction to prevent key material appearing in output
  • Validation aligned with the transport layer's key requirements

3. Lint and config fixes
Refactored constant conditions and updated stale globals declarations in
the transport layer and test suite, restoring clean lint and typecheck passes.

**

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 29, 2026

@MickeeJay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@adams813
Copy link
Copy Markdown
Collaborator

adams813 commented May 3, 2026

Nice Implementation, LGTM!

@adams813 adams813 merged commit 91f61b1 into benelabs:main May 3, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Logic for Encrypted IPC Communication

2 participants