Fix/encrypted ipc transport#280
Merged
adams813 merged 3 commits intobenelabs:mainfrom May 3, 2026
Merged
Conversation
|
@MickeeJay Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
Nice Implementation, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Wire encrypted stdio IPC transport into server entry point — closes #72
Summary
The encrypted transport logic was partially implemented but never wired into
the main server entry point. Configuration schemas were also missing the
necessary key fields, and several lint and config errors blocked the code
from building or running correctly in CI. This PR completes the integration,
making encrypted stdio IPC fully operational when a key is provided.
Problem
Three gaps blocked the feature from being functional end-to-end:
src/index.tsdid not conditionally select the encrypted transport factorywhen a key was present — the implementation existed but was never invoked
PULSAR_IPC_ENCRYPTION_KEYwas absent from the configuration schema,so the key could not be read or validated at startup
constant conditions,stale
globals) prevented clean builds and reliable CI runsWhat Changed
1. Server entry point — encrypted transport wiring
Updated
src/index.tsto use the encrypted transport factory whenPULSAR_IPC_ENCRYPTION_KEYis present, falling back to the standardtransport when no key is configured.
2. Configuration —
PULSAR_IPC_ENCRYPTION_KEYAdded the key to the configuration schema with:
3. Lint and config fixes
Refactored constant conditions and updated stale
globalsdeclarations inthe transport layer and test suite, restoring clean lint and typecheck passes.
**