feat: Implement Request ID Tracing for Tool Execution Chains (#107)#287
Merged
adams813 merged 2 commits intobenelabs:mainfrom May 3, 2026
Merged
feat: Implement Request ID Tracing for Tool Execution Chains (#107)#287adams813 merged 2 commits intobenelabs:mainfrom
adams813 merged 2 commits intobenelabs:mainfrom
Conversation
|
@TochukwuJustice Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Collaborator
|
Nice implementation, lgtm! |
Contributor
Author
thanks man.. please merge PRs |
Collaborator
|
Nice Implementation, LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #107
Summary of Changes:
Context Layer (src/logger.ts): Exported requestContext, a typed AsyncLocalStorage<{ requestId: string }>. Added a Pino mixin() that automatically injects request_id into every log entry emitted during a request — no additional code needed at any call site.
Tracing Middleware (src/index.ts): Wrapped each tool execution in requestContext.run(). A request_id is extracted from tool arguments if provided by the client; otherwise a cryptographically unique UUID is auto-generated via node:crypto.
Header Propagation (src/services/horizon.ts): Updated getHorizonServer() to read the active request context and forward X-Request-ID to every outgoing Stellar Horizon API call, enabling end-to-end tracing.
Unit Tests (tests/unit/tracing.test.ts): 4 tests covering context isolation, propagation, lifecycle, and concurrent request safety — all passing.
Reason for Changes: Complex multi-tool execution chains in MCP servers are difficult to debug without a consistent correlation ID. This implementation establishes a zero-overhead tracing layer that links logs, tool execution, and outgoing Stellar network requests under a single request_id.