Run unit test only on PR

.github/workflows/acceptance_test.yml

@@ -2,9 +2,6 @@
 name: "Acceptance Testing"
 
 on: 
-  push:
-    branches:
-      - "*"
   pull_request:
     branches:
       - "main"

.github/workflows/lint.yaml

@@ -2,9 +2,9 @@
 name: "Lint testing"
 
 on: 
-  push:
+  pull_request:
     branches:
-      - "*"
+      - "main"
 
 jobs:
   setup_matrix:

.github/workflows/unit_tests.yml

@@ -2,9 +2,9 @@
 name: "Unit Testing"
 
 on: 
-  push:
+  pull_request:
     branches:
-      - "*"
+      - "main"
 
 jobs:
   setup_matrix:

CHANGELOG.md

@@ -6,7 +6,7 @@ All notable changes to this project will be documented in this file.
 
 **Upgrade warning**
 
-The following default parameters for passwords have been removed from the modules. 
+The following default parameters for passwords have been removed from the module.
 - observium::db_password
 - observium::rootdb_password
 - observium::snmpv3_authpass
@@ -23,7 +23,7 @@ If you were relying on these defaults you will need to set them in your control
 - Bumped module dependencies to later versions.
 - Bumped PDK version to 3.2.0.
 - Lint and other minor fixes. 
-- Added lint, unit and litmus tests within Github actions. 
+- Added lint, unit and litmus tests within Github actions pipeline.
 
 Thanks to https://github.com/baile320 for their security recommendations for this release. :)
 

README.md

@@ -74,7 +74,7 @@ class { 'observium':
 ```
 
 2. Via environment hiera. (Preferred as we can encrypt these values)
-Within environment hiera place the values as shown.
+Within environment hiera place the values like shown.
 ```
 ---
 observium::db_password: "your_password_here"
@@ -185,7 +185,7 @@ RHEL 9 require the following yum repos for installation - these will be automati
 
 - [EPEL][4]
 - [OpenNMS common][5]
-- [OpenNMS RHEL8][13]
+- [OpenNMS RHEL9][13]
 - [remi-modular][14] - note you will need to enable php8.2 after adding this repo 
 ```
 /bin/dnf module -y install php:remi-8.2

REFERENCE.md

@@ -15,7 +15,7 @@
 * `observium::apache`: Class: observium::apache inherits observium  Configure apache server with virtual host for observium
 * `observium::config`: Class: observium::config  Configure observium configuration files  lint:ignore:140chars lint:ignore:arrow_alignment
 * `observium::database_init`: Class: obversium  Init the observium database after install.  lint:ignore:140chars
-* `observium::firewall`: Class: observium::firewall  Manage UFW on ubuntu
+* `observium::firewall`: Class: observium::firewall  Manage iptables on ubuntu
 * `observium::firewalld`: Class: observium::firewall  Manages firewall and opens ports for observium
 * `observium::install`: Class: observium::install  Creates folder structure for Observium, and install from tar
 * `observium::mariadb`: Class: observium::mariadb  Install mysql or mariadb - OS dependant
@@ -203,7 +203,7 @@ Valid options - ['AES','DES']
 
 Data type: `Array`
 
-Array Snmp_agentaddress - default ['udp:127.0.0.1:161','udp6:[::1]:161']
+An array of addresses, on which snmpd will listen for queries. - default ['udp:127.0.0.1:161','udp6:[::1]:161']
 
 ##### <a name="-observium--mib_locations"></a>`mib_locations`
 

manifests/init.pp

@@ -63,7 +63,7 @@
 #     Valid options - ['AES','DES']
 # 
 # @param snmpd_agentaddress
-#     Array Snmp_agentaddress - default ['udp:127.0.0.1:161','udp6:[::1]:161']
+#     An array of addresses, on which snmpd will listen for queries. - default ['udp:127.0.0.1:161','udp6:[::1]:161']
 #
 # @param mib_locations
 #     Miblocations for observium to add to snmp.conf, default ['/opt/observium/mibs/rfc','/opt/observium/mibs/net-snmp']
@@ -177,7 +177,7 @@
   Enum['SHA','MD5']                            $snmpv3_authalgo,
   String                                       $snmpv3_cryptopass,
   Enum['AES','DES']                            $snmpv3_cryptoalgo,
-  Array                                        $snmpd_agentaddress, # need to document if this stays in module 
+  Array                                        $snmpd_agentaddress,
   Array                                        $mib_locations,
   Array                                        $additional_mib_location      = [],
   Array                                        $additional_snmp_conf_options = [],