Completed core flow translations on i18n-fix branch — ready for review and merge#191
Completed core flow translations on i18n-fix branch — ready for review and merge#191bestian wants to merge 72 commits intoberkmancenter:stagingfrom
Conversation
1. 先用正規表示法text: '(\w|\s)+'找到翻譯的靜態文字所在檔案及位置 2. 請cursor幫忙生成。指令如："為這一頁所有的靜態文字還沒有翻譯的都增加翻譯，確保英文的部份和原本的靜態文字相同"
清理重覆的內容
note: noCancel 已存在，不用加
note:(其中有變數嵌入的不確定對不對，請再幫忙double check一下) client/lib/features/admin/presentation/views/events_tab.dart, client/lib/features/admin/presentation/views/members_tab.dart, client/lib/features/admin/presentation/views/overview_tab.dart, client/lib/features/events/features/live_meeting/data/providers/live_meeting_provider.dart
client/lib/features/admin/presentation/views/community_admin.dart client/lib/features/admin/presentation/views/settings_tab.dart
client/lib/features/admin/presentation/views/billing_tab.dart
create_community_dialog.dart create_community_tags.dart community_home.dart(partial) create_tag_widget.dart
|
Hi team, thank you for your great work on this project! Just a gentle reminder: this PR only involves translation updates and does not modify any core functionality. If possible, may I kindly ask for an earlier review? We’ve encountered some ongoing merge conflicts, and an earlier merge would help us stay in sync with the latest changes. Thank you so much for your time and support! 🙏 |
|
Hi Bestian! Thank you for the nudge and sorry for the delay! I'll make sure I review this and get it back to you in the next day or so. |
|
@bestian @audreyt Thank you for this, and for your patience! We're doing final fixes to get everything on the staging branch tested and deployed to production. We won't be merging anything new until after that happens. This release includes all of the theme work and all of the i18n work thus far. After these theme changes we should be able to avoid large, bundled deployment packages like this one. It's caused a bottleneck, and we’re aiming for a faster, more incremental improvements in the future. |
|
Thank you for your explanation and instructions. I hope you can successfully overcome the bottleneck and deploy the project online smoothly. The Taiwanese community is also looking forward to using Frankly for online meetings. |
The remaining failures are all third-party SDK compatibility issues and do not affect the normal development and operation of the project.
|
Just took a look at the couple updates, thanks Bestian! I'm rerunning the workflows now. |
…t passed, to be fixed later)
|
Sorry, there are still some test errors. perhaps they are related to localization. I'll try to fix them by fix automatic test files. Please wait for a few days. |
|
After debugging, now every auto-test |
Modify the test's expected value to match the Localization value, rather than stuffing it with Test_helper.dart. This makes the test truly meaningful, rather than meaningless.
|
@epenn I debugged the error in this PR, please make a review when convinent. Thank you! |
|
Hi @bestian! Apologies for the huge delay on circling back to this PR. But thank you so much for submitting this, along with your other work on Frankly as well! We certainly all appreciate it! Since it’s been a while for this one, and we know that there have been many updates to the content on Frankly in the interim, would you be willing to submit a new i18n PR on the basis of the current version of Frankly? If so I’ll close this one in favor of that. That’s not ideal of course, but that might be the most practical approach given the time in between. (And sorry again about that.) |
Hi @epenn ! Thanks so much for the kind words, and no worries at all about the timing — totally understandable 🙂 That sounds doable to me. I’ll create a new branch named To make things easier to review and merge, I’m also happy to break the work into smaller chunks and submit incremental PRs, so you can merge things step by step rather than all at once. Thanks again, and looking forward to continuing this! |
5 participants
What is in this PR?
In this PR, my collaborator and I completed most of the translations for the core user flows in Traditional Chinese (zh-Hant-TW), Simplified Chinese (zh), and Spanish (es), providing a more localized experience for users across different languages.
We also resolved version conflicts that arose during the integration of these translations to ensure the codebase remains stable and functional.
Changes in the codebase
Changes outside the codebase
Testing this PR
To test:
Switch the language to Traditional Chinese (zh-Hant-TW), Simplified Chinese (zh), and Spanish (es).
Walk through the main user flows such as:
Confirm that all key UI elements are correctly translated.
Check for any layout issues caused by long translated text (e.g., text overflow or misalignment).
Additional information
This round of translation focuses primarily on the core user interaction flows. Some secondary or less frequently accessed views may remain untranslated and will be addressed in future contributions.