Draft
Conversation
…out issues), remove dedicated device-size specific code, update membership permission text.
…n removing Expanded from description text / setting Column's size to min to allow the menu items to render. Added 8px vertical padding on items.
# Conflicts: # client/lib/features/admin/presentation/views/events_tab.dart # client/lib/features/admin/presentation/views/members_tab.dart # client/lib/features/admin/presentation/views/overview_tab.dart # client/lib/features/admin/presentation/views/settings_tab.dart
…aTab; resolve linter library_private_types_in_public_api.
Contributor
Author
|
@katherineqian thank you for taking the time to get a review in! I resolved all of your items! |
2 tasks
Contributor
|
New preview link here: https://gen-hls-bkc-7627--jr-refactor-m3-community-k4kznj6i.web.app/ |
Contributor
|
New preview link here: https://gen-hls-bkc-7627--jr-refactor-m3-community-6cm4ayd6.web.app |
Fortunately our placeholder is just a URI derived from a hash derived from the community's ID so this is a one-liner!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
As per #186, this change set re-implements the community admin interface to use M3 components, add new functionality where relevant.
Changes in the codebase
TabBarView, built-inTabControllerrather thanCustomTabBarViewas the encompassing containment for all admin sections.MembershipStatus.attendeeand update all others descriptions.CupertinoSwitchto MaterialSwitch.CustomTextField.Flexwidget with conditional direction based on device type in order to simplify layout code.CreateCommunityDialog.PaginatedDataTable, allow for real time filtering of members.MemberDataUtilsclass, newDataTabclass, remove deprecatedEventsTab.ChooseColorSectionto use a tab controller for preset/custom colors selection, new grid format for presets. Implemented flutter_colorpicker for custom color selection.CloudFunctionsCommunityService.SettingsTabto divide toggles into sections, use updated Material components.Communitymodel and overview form.Fixes #264
Testing this PR