rename all instance of meeting guide to meeting template in codebase#291
Open
karenunify wants to merge 11 commits intoberkmancenter:stagingfrom
Open
rename all instance of meeting guide to meeting template in codebase#291karenunify wants to merge 11 commits intoberkmancenter:stagingfrom
karenunify wants to merge 11 commits intoberkmancenter:stagingfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR performs a comprehensive semantic renaming throughout the codebase, replacing all instances of "meetingGuide", "MeetingGuide", and "meeting_guide" with "meetingTemplate" and its variants. The renaming affects function names, class names, variable names, file names, directory names, and import statements across both the client and Firebase functions codebases.
Changes:
- Renamed all classes, functions, variables, and files from "meetingGuide" to "meetingTemplate" nomenclature
- Updated all import statements to reference the new file paths
- Regenerated all generated code files (.g.dart, .freezed.dart) with correct part declarations
- Updated test files and mock classes to use the new naming
Reviewed changes
Copilot reviewed 70 out of 71 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| firebase/functions/test/util/live_meeting_test_utils.dart | Updated import from meeting_guide.dart to meeting_template.dart |
| firebase/functions/test/events/live_meetings/*.dart | Updated imports and test references to use meeting_template |
| firebase/functions/node/main.dart | Updated import and registration of CheckAdvanceMeetingTemplate function |
| firebase/functions/lib/events/live_meetings/*.dart | Renamed CheckAdvanceMeetingGuide class to CheckAdvanceMeetingTemplate and all related methods |
| data_models/lib/events/live_meetings/meeting_template.dart | Updated part declarations to reference meeting_template instead of meeting_guide |
| data_models/lib/events/live_meetings/meeting_template.g.dart | Regenerated with correct part declaration |
| data_models/lib/events/live_meetings/meeting_template.freezed.dart | Regenerated with correct part declaration |
| data_models/lib/events/live_meetings/live_meeting.g.dart | Contains unrelated timestamp handling changes alongside expected updates |
| data_models/lib/cloud_functions/requests.dart | Renamed CheckAdvanceMeetingGuideRequest to CheckAdvanceMeetingTemplateRequest |
| data_models/lib/cloud_functions/requests.g.dart | Regenerated with renamed request class |
| data_models/lib/cloud_functions/requests.freezed.dart | Regenerated with renamed request class |
| client/test/mocked_classes.dart | Updated imports to use meeting_template paths |
| client/test/mocked_classes.mocks.dart | Regenerated mocks with renamed classes (e.g., MockFirestoreMeetingTemplateService) |
| client/test/lib/features/.../meeting_template_card_item_user_suggestions_presenter_test.dart | Updated all test references to use meeting_template naming |
| client/test/lib/features/.../agenda_item_presenter_test.dart | Updated mock variable names to use meeting_template naming |
| client/test/lib/features/.../agenda_item_helper_test.dart | Updated mock variable names and test descriptions |
| client/lib/services.dart | Updated service registration and getters for FirestoreMeetingTemplateService |
| client/lib/features/events/.../meeting_dialog.dart | Updated provider creation to use MeetingTemplateCardStore |
| client/lib/features/events/.../live_meeting_mobile_page.dart | Updated all references to MeetingTemplateCardStore and related components |
| client/lib/features/events/.../live_meeting_mobile_presenter.dart | Updated field names and method calls to use meeting_template naming |
| client/lib/features/events/.../participant_widget.dart | Updated Provider references to MeetingTemplateCardStore |
| client/lib/features/events/.../video_flutter_meeting.dart | Updated all component references to use MeetingTemplateCard and related classes |
| client/lib/features/events/.../conference_room.dart | Renamed meetingGuideCardModel field to meetingTemplateCardModel |
| client/lib/features/events/.../meeting_template/presentation/*.dart | All presenter, view, and widget files renamed and updated |
| client/lib/features/events/.../meeting_template/data/*.dart | All data models, services, and providers renamed and updated |
| client/lib/features/events/.../meeting_agenda/*.dart | Updated references to MeetingTemplateCardStore |
| client/lib/features/events/.../meeting_guide/*.dart | Old files deleted (contract and model files) |
| client/lib/features/events/.../cloud_functions_live_meeting_service.dart | Updated method name to checkAdvanceMeetingTemplate |
Comments suppressed due to low confidence (2)
client/lib/features/events/features/live_meeting/features/meeting_template/data/providers/meeting_template_card_store.dart:34
- Comment references "meeting guide card" but should be updated to "meeting template card" for consistency with the renaming effort.
client/lib/features/events/features/live_meeting/features/meeting_template/data/providers/meeting_template_card_store.dart:38 - Comment references "meeting guide card" but should be updated to "meeting template card" for consistency with the renaming effort.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...es/events/features/live_meeting/features/video/presentation/views/video_flutter_meeting.dart
Outdated
Show resolved
Hide resolved
...es/events/features/live_meeting/features/video/presentation/views/video_flutter_meeting.dart
Outdated
Show resolved
Hide resolved
Contributor
|
DMing with Karen to triage the warning + error that she's receiving during the build step. Unclear yet on whether this is just a permissions issue or an actual error that needs to be resolved. |
Contributor
|
Update from talking to Karen again — Turned out the issue was actually due to a GitHub Actions outage of all things, so this should be reviewable now. I'll be able to circle back to this in the next couple days. |
saihla
requested review from
katherineqian
and removed request for
epenn and
mikewillems
Collaborator
|
Reviewed this; all good in the code. One caveat (GH actually caught this but was right): please update the comments in ...
so that we keep clarity around the naming. Also, please go ahead and run a |
mikewillems
requested changes
Feb 13, 2026
Collaborator
mikewillems
left a comment
mikewillems
left a comment
There was a problem hiding this comment.
Reviewed this; all good in the code.
One caveat (GH actually caught this but was right): please update the comments in ...
client/lib/features/events/features/live_meeting/features/meeting_agenda/data/providers/meeting_agenda_provider.dart
client/lib/features/events/features/live_meeting/features/meeting_guide/data/providers/meeting_guide_card_store.dart
so that we keep clarity around the naming. Also, please go ahead and run a git merge origin/staging and re-push to pull in all the commits since. Other than that, great!
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 75 out of 76 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Hey @mikewillems - is this good to go? Wanted to check in since you have a pending "request changes" review :) |
Collaborator
Please don't hate me, really sorry to nitpick and for not catching this before, but
|
Collaborator
|
@karenunify In fact, I finally pulled down your branch, and expanding the search to include just "guide" (case insensitive), I see the language used in a ton more places. I used grep (and spent too long making this search because I'm a nerd and also couldn't figure out how to copy all the filename instances from the vscode search): but you can just use the vscode search for case-insensitive instances of 'guide', and ignore the top level files in ./ and ./client, and the rest all seem to be instances of the old naming. This seems to be the complete list of non-generated source files still using "guide" semantically instead of "template" (It could be a superset, but I looked not-carefully at all these and think I removed any that aren't using "guide" specifically to mean what we call "template"). Make sure to also build locally to regenerate the .arb (l10n) files and commit those too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
This PR replaces all instances of "meetingGuide", "MeetingGuide", "meeting_guide" with "meetingTemplate", etc. stemming from a larger semantic renaming effort.
Changes in the codebase
It was discovered in the analytics code that the term "guide" was also sometimes used interchangeably with "template".
All functions, variables, file names, and directory names in the codebase that referenced and combination of "meetingGuide", "MeetingGuide", "meeting_guide" have been replaced with "meetingTemplate", etc.