Skip to content

Implement super editor for agenda items#78

Closed
jencompgeek wants to merge 8 commits intostagingfrom
28-super-editor-agenda-items
Closed

Implement super editor for agenda items#78
jencompgeek wants to merge 8 commits intostagingfrom
28-super-editor-agenda-items

Conversation

@jencompgeek
Copy link
Collaborator

@jencompgeek jencompgeek commented Feb 25, 2025 •
edited
Loading

What is in this PR?

Changes in the codebase

Changes outside the codebase

Testing this PR

Additional information

Still a few known issues here:

  • Look and feel - too much padding in text editor window, toolbar looks different than other components style-wise
  • Text selection - Ran into some issues with selecting text with a mouse on desktop. See comments in the code. The easiest way I found to fix was to keep text selected even when editor completely loses focus, but visually that's not ideal. Maybe you can find another way?
  • There are some commented components in the text editor class that may be needed for Android. Need to find a way to test on Android.
  • Everything in the editor seems double spaced by default, but the actual single and double line breaks do get preserved correctly and displayed when viewing (not editing) the card
  • Mobile text selection - see screenshot for weird double text selection on iPhone Chrome and Safari when double tapping. It gets very weird if you try scrolling with it. Also, prob not related to Super Editor, but the + button for creating events is in the way.....

phoneselection

@jencompgeek
Upgrade to Flutter 3.27.4 (Dart 3.6)
1023035 
    * Update build_runner and frontend_server_client dependencies in data_models and functions to allow build_runner to work with this Dart version. See dart-lang/sdk#55911
    * Update Flutter version in GitHub workflow files
    * Commit updated live_meeting.g.dart generated file, which appears now to use timestamp functions similar to other generated files.
@jencompgeek
Add super_editor dependencies to client
39140ba
@jencompgeek
Remove extra newline added to markdown agenda item content
bad0048
@jencompgeek
Add rich editor with toolbar for text agenda items
2085c3b 
* Uses super_editor package to create toolbar for editing text agenda items, including Bold, Italics, Links, and Headings
* Translates markdown to text as you edit
* Translates text to markdown on save
@jencompgeek
Demonstrate how to enable super_editor logging (remove me)
539346e
@jencompgeek jencompgeek linked an issue Feb 25, 2025 that may be closed by this pull request
Implement rich text editor for agenda items #28
Open
14 tasks
@github-actions
Copy link

github-actions bot commented Feb 25, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 1ffc4f1):

https://gen-hls-bkc-7627--pr78-28-super-editor-agen-ifh767dr.web.app

(expires Tue, 15 Apr 2025 15:56:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: eed668cca81618d491d024574a8f8a6003deaa8d

@jencompgeek jencompgeek marked this pull request as draft February 25, 2025 18:21
@katherineqian katherineqian added the enhancement New feature or request label Jun 2, 2025
@saihla
Copy link
Collaborator

saihla commented Jan 8, 2026

replaced by #260

@saihla saihla closed this Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement rich text editor for agenda items

4 participants

@jencompgeek @saihla @johnnycrich @katherineqian