TEST reviewdog chin #2
Conversation
Signed-off-by: Bernhard Kaindl <[email protected]>
.pre-commit-config.yaml: - Use the tox hook to run pylint and pytype - Update hook versions and mypy dependencies Also remove the obsolete typing stub stubs/pytest_httpserver.pyi Signed-off-by: Bernhard Kaindl <[email protected]>
tox: - Fix running pytype static analysis from tox - Require minium tox version: Replace obsolete tox version workarounds - pytype_runner.py: Create the output directory if needed - Cleanup test extras (dependencies) for obsolete python versions
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
…eted docs) Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
move DMV common code to python-libs because RPU plugin calls these functions as well Signed-off-by: Chunjie Zhu <[email protected]>
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
chunjiez/master
branch
3 times, most recently
from
2f73acb to
66b930e
Compare
| loaded = oldone["loaded modules"] + newone["loaded modules"] | ||
| json_formatted["loaded modules"] = loaded | ||
|
|
||
| self.dmv_list["drivers"][oldone["info"]] = json_formatted |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Unsupported target for indexed assignment ("object") [index]
| self.dmv_list["drivers"][oldone["info"]] = json_formatted | ||
|
|
||
| def process_dmv_data(self, json_data, json_formatted): | ||
| if not json_data["name"] in self.dmv_list["drivers"]: |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Unsupported right operand type for in ("object") [operator]
|
|
||
| def process_dmv_data(self, json_data, json_formatted): | ||
| if not json_data["name"] in self.dmv_list["drivers"]: | ||
| self.dmv_list["drivers"][json_data["name"]] = json_formatted |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Unsupported target for indexed assignment ("object") [index]
| def process_dmv_data(self, json_data, json_formatted): | ||
| if not json_data["name"] in self.dmv_list["drivers"]: | ||
| self.dmv_list["drivers"][json_data["name"]] = json_formatted | ||
| elif self.dmv_list["drivers"][json_data["name"]] is None: |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Value of type "object" is not indexable [index]
| if not json_data["name"] in self.dmv_list["drivers"]: | ||
| self.dmv_list["drivers"][json_data["name"]] = json_formatted | ||
| elif self.dmv_list["drivers"][json_data["name"]] is None: | ||
| self.dmv_list["drivers"][json_data["name"]] = json_formatted |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Unsupported target for indexed assignment ("object") [index]
| elif self.dmv_list["drivers"][json_data["name"]] is None: | ||
| self.dmv_list["drivers"][json_data["name"]] = json_formatted | ||
| else: | ||
| self.merge_jsondata(self.dmv_list["drivers"][json_data["name"]], json_formatted) |
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Value of type "object" is not indexable [index]
bernhardkaindl
force-pushed
the
chunjiez/master
branch
5 times, most recently
from
250c00d to
7027486
Compare
xcp/dmv.py
Outdated
| for _, updates_dir, dmv_dir in get_all_kabi_dirs(): | ||
| if not os.path.isdir(dmv_dir): | ||
| continue | ||
|
|
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
C0303: Trailing whitespace (trailing-whitespace)
xcp/dmv.py
Outdated
| return True | ||
| return id1 == id2 | ||
|
|
||
| ''' |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0105: String statement has no effect (pointless-string-statement)
| import re | ||
| import struct | ||
| import subprocess | ||
| from typing import Any, Dict |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused Any imported from typing (unused-import)
| import re | ||
| import struct | ||
| import subprocess | ||
| from typing import Any, Dict |
There was a problem hiding this comment.
[pylint] reported by reviewdog 🐶
W0611: Unused Dict imported from typing (unused-import)
bernhardkaindl
force-pushed
the
chunjiez/master
branch
from
7027486 to
e037e4a
Compare
Signed-off-by: Bernhard Kaindl <[email protected]>
bernhardkaindl
force-pushed
the
chunjiez/master
branch
from
e037e4a to
539004a
Compare
bernhardkaindl
force-pushed
the
master
branch
5 times, most recently
from
b5c6d16 to
13a6c0d
Compare
bernhardkaindl
force-pushed
the
master
branch
7 times, most recently
from
8a18101 to
2534106
Compare
No description provided.