Standardize bsg_mem width_p parameter - #734
Open
dpetrisko wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the parameter naming convention for data width in bsg_mem_1rw_sync_mask_write_byte modules by renaming data_width_p to width_p to align with other bsg_mem modules like bsg_mem_1rw_sync.
Changes:
- Renamed
data_width_pparameter towidth_pacross allbsg_mem_1rw_sync_mask_write_bytemodule definitions and instantiations - Updated all derived parameters, port declarations, and usage sites to reference
width_p - Updated display messages and error messages to reflect the new parameter name
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testing/bsg_mem/bsg_mem_1rw_sync_segmented/test_bsg.sv | Updated test instantiation to use width_p |
| testing/bsg_mem/bsg_mem_1rw_sync_mask_write_byte_segmented/test_bsg.sv | Updated test instantiation to use width_p |
| hard/ultrascale_plus/bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition and all references from data_width_p to width_p |
| hard/ultrascale_plus/2019.1/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition and all references from data_width_p to width_p |
| hard/tsmc_40/bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition, macros, and instantiations to use width_p |
| hard/tsmc_28/bsg_mem/bsg_mem_1rw_sync_mask_write_byte_macros.svh | Updated macro definitions to use width_p |
| hard/tsmc_180_250/bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition and all references from data_width_p to width_p |
| hard/tsmc_16/bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition and all references from data_width_p to width_p |
| hard/saed_90/bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition, macros, and instantiations to use width_p |
| hard/pickle_40/bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition, macros, and instantiations to use width_p |
| hard/gf_14/bsg_mem/bsg_mem_1rw_sync_mask_write_byte_macros.svh | Updated macro definitions to use width_p |
| hard/generic/bsg_mem/bsg_mem_1rw_sync_mask_write_byte_macros.svh | Updated macro definitions to use width_p |
| hard/fakeram/bsg_mem_1rw_sync_mask_write_byte_macros.svh | Updated macro definitions to use width_p |
| hard/common/bsg_mem/bsg_mem_generator.py | Updated code generation template to use width_p |
| bsg_mem/bsg_mem_banked_crossbar.sv | Updated instantiation to use width_p parameter name |
| bsg_mem/bsg_mem_1rw_sync_segmented.sv | Updated instantiation to use width_p parameter name |
| bsg_mem/bsg_mem_1rw_sync_mask_write_byte_synth.sv | Updated module definition and all references from data_width_p to width_p |
| bsg_mem/bsg_mem_1rw_sync_mask_write_byte_segmented.sv | Updated instantiation to use width_p parameter name |
| bsg_mem/bsg_mem_1rw_sync_mask_write_byte_banked.sv | Updated module definition and all references from data_width_p to width_p |
| bsg_mem/bsg_mem_1rw_sync_mask_write_byte.sv | Updated module definition and all references from data_width_p to width_p |
| bsg_cache/bsg_cache_non_blocking_data_mem.sv | Updated instantiation to use width_p parameter name |
| bsg_cache/bsg_cache.sv | Updated instantiation to use width_p parameter name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, only bsg_mem_1rw_sync_mask_write_byte and friends use data_width_p while other memories use width_p. This makes scripted parsing harder and instantiation more confusing
This PR fixes this discrepancy and standardizes width_p as bsg_mem parameter name