Skip to content

fix(detail): stabilize image-area height to stop the per-switch layout jump (CLS) #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zheaoli merged 1 commit into from
Jun 11, 2026
Merged

fix(detail): stabilize image-area height to stop the per-switch layout jump (CLS) #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions components/album/preview-image.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,12 @@ export default function PreviewImage(props: Readonly<PreviewImageHandleProps>) {
>
<TransitionOverlay />
<div className="relative h-full flex flex-col space-y-2 sm:grid sm:gap-4 sm:grid-cols-3 w-full">
<div className="show-up-motion relative sm:col-span-2 sm:flex sm:justify-center sm:max-h-[90vh] select-none">
<div className="overflow-hidden w-full" ref={emblaRef}>
{/* Fixed 90vh height on desktop (not max-h) so the image area never
resizes to each photo's aspect ratio — different aspects letterbox
within a constant box instead of changing the row height on every
switch (that height jump was the remaining "flicker"). CLS≈0. */}
<div className="show-up-motion relative sm:col-span-2 sm:flex sm:justify-center sm:h-[90vh] select-none">
<div className="overflow-hidden w-full sm:h-full" ref={emblaRef}>
<div className="flex h-full">
{photos.map((photo, i) => {
const near = Math.abs(i - index) <= loadRadius
Expand All @@ -441,7 +445,7 @@ export default function PreviewImage(props: Readonly<PreviewImageHandleProps>) {
<div
key={photo.id}
data-flip-target={isCurrent ? '' : undefined}
className="relative flex min-w-0 shrink-0 grow-0 basis-full items-center justify-center sm:max-h-[90vh]"
className="relative flex min-w-0 shrink-0 grow-0 basis-full items-center justify-center sm:h-full"
>
{near ? (
photo.type === 1 ? (
Expand Down
Loading