GHA pre-review: get the test list using dry-run once only#10139
Closed
macfarla wants to merge 3 commits intobesu-eth:mainfrom
Closed
GHA pre-review: get the test list using dry-run once only#10139macfarla wants to merge 3 commits intobesu-eth:mainfrom
macfarla wants to merge 3 commits intobesu-eth:mainfrom
Conversation
…nner Signed-off-by: Sally MacFarlane <[email protected]>
macfarla
added
the
dev experience
macfarla
changed the title
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Contributor
Author
|
latest run with this last change was still 24 min for pre-review (previously 18 min) so I don't think it's a net win. |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it's run once on each runner (so x14). Dry-run includes compile and dependency resolution.
This PR relocates test class enumeration to the spot where ./gradlew build is already running which already is doing compile and dependency resolution. This will reduce the number of times we call out to get all dependencies.