Feat: add project sorting by sector #1592
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sorting on sector
Removed redundant badges for sectors and priority from ProjectCard.vue to simplify UI. Updated projectSorter.ts to use a more relevant store for checking company data selection, improving logic clarity and maintainability.
Updated project sorting functionality to include a new method for sorting by sector when company data is selected. Refactored existing code to improve reusability and integrate the sector-based sorting across multiple components. Enhanced UI by adding badges for sector count and priority in project cards.
Refactored sorting to remove redundant methods and improve clarity by directly sorting within reactive projects. Simplified badge rendering in `ProjectCard.vue` to better reflect the project's priority and remove unused logic.
Updated filters across multiple components and utilities to use `isCompanyDataSelected()` instead of directly accessing `filters[FilterItemKeys.companyData]`. This improves readability, encapsulates logic, and streamlines future maintenance.
# Conflicts: # apps/nuxt/src/components/catalog/CatalogProjects.vue # apps/nuxt/src/components/home/TeeHomeProjectList.vue # apps/nuxt/src/components/questionnaire/result/list/ResultProjectList.vue # apps/nuxt/src/tools/project/projectSorter.ts
Introduced interfaces for project eligibility and sorting. Updated filtering logic to support new query parameters like `onlyEligible` and `sortBy`. Simplified integration of tools across backend and frontend components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette pull request se concentre sur l'introduction d'une nouvelle méthode de filtre et la modification de la logique de tri des projets.
Mises à jour du store des filtres :
isCompanyDataSelectedau store des filtres pour vérifier si les données de l'entreprise sont sélectionnées. [1] [2]Simplification et refactorisation du code :
projectFilter.tsen consolidant les imports du même module.byProgramsde la classeProjectFilter.ProjectSorterpour inclure un mécanisme de tri conditionnel basé sur le filtreisCompanyDataSelected.