Skip to content

Asset title unreadable on light background #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hankjordan opened this issue Mar 18, 2025 · 6 comments · Fixed by #1953 · May be fixed by #1952
Closed

Asset title unreadable on light background #1951

hankjordan opened this issue Mar 18, 2025 · 6 comments · Fixed by #1953 · May be fixed by #1952
Labels
A-Assets The collection of ecosystem crates found on the Bevy Assets page C-Webdev S-Ready-For-Implementation The core questions are answered: just add code

Comments

@hankjordan
Copy link
Contributor

Image

@rparrett
Copy link
Contributor

Could you provide more information about your browser/environment? I can't reproduce in any of the browsers at my immediate disposal on macOS.

Image

@hankjordan
Copy link
Contributor Author

Could you provide more information about your browser/environment? I can't reproduce in any of the browsers at my immediate disposal on macOS.
Image

Linux, Firefox

@rparrett
Copy link
Contributor

It seems likely that this was broken by #1771.

@rparrett
Copy link
Contributor

cc @doup

@doup
Copy link
Contributor

doup commented Mar 18, 2025

Oh no, it's because of CSS Relative Colors. I saw that this is a 2024 Baseline feature, but I didn't realize that there are two tiers: newly available and widely available. CSS Relative Colors is newly available. 🙈

10% of the users don't have support, most of them (except Firefox and Samsung users) using quite old browsers.

Image

I suspect that Cart will prefer this fixed instead asking users to upgrade their browser.

I'll try to fix it during the week. So sad. 🥲🥲🥲

@hankjordan
Copy link
Contributor Author

Oh no, it's because of CSS Relative Colors. I saw that this is a 2024 Baseline feature, but I didn't realize that there are two tiers: newly available and widely available. CSS Relative Colors is newly available. 🙈

10% of the users don't have support, most of them (except Firefox and Samsung users) using quite old browsers.

Image

I suspect that Cart will prefer this fixed instead asking users to upgrade their browser.

I'll try to fix it during the week. So sad. 🥲🥲🥲

Well this was a great way to find out my browser was horribly out of date 🙈
Works on latest firefox, but I still think my PR improves readability

@alice-i-cecile alice-i-cecile added A-Assets The collection of ecosystem crates found on the Bevy Assets page C-Webdev S-Ready-For-Implementation The core questions are answered: just add code labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets The collection of ecosystem crates found on the Bevy Assets page C-Webdev S-Ready-For-Implementation The core questions are answered: just add code
Projects
None yet
4 participants