Skip to content

Remove CSS Relative Colors usage #1953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 2, 2025
Merged

Remove CSS Relative Colors usage #1953

merged 5 commits into from
Apr 2, 2025

Conversation

doup
Copy link
Contributor

@doup doup commented Mar 18, 2025 •
edited
Loading

#1771 introduced the usage of CSS Relative Colors but this feature is not widely available yet (even if it's part of the 2024 Baseline). This PR moves the relative colors computation from CSS to SASS.

Once CSS Relative Colors has wide support this PR should be reverted.

Fixes #1951
Fixes #1937

@doup doup marked this pull request as ready for review March 18, 2025 16:33
@doup doup mentioned this pull request Mar 18, 2025
Open
alice-i-cecile
alice-i-cecile reviewed Mar 20, 2025
View reviewed changes
@alice-i-cecile alice-i-cecile added C-Bug A problem with the code that runs the site C-Webdev S-Needs-Review labels Mar 20, 2025
@doup @alice-i-cecile
Update sass/_vars.scss
74ecf5d 
Co-authored-by: Alice Cecile <[email protected]>
@doup doup requested a review from alice-i-cecile March 21, 2025 09:26
kristoff3r
kristoff3r approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@kristoff3r kristoff3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a modern browser and the asset page works, I don't have an easy way of testing if it actually fixes the issue.

@doup
Copy link
Contributor Author

doup commented Mar 29, 2025

image
(couldn't resist, I've played Titanfall 2 recently…)

Anyway, I didn't test it on an older browser, I just double checked that the SASS equivalent rgba() calls were using the correct color and alpha. I think that's enough as we're quite sure from the user that reported the issue that CSS Relative Colors is the problem.

bushrat011899
bushrat011899 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Hopefully it can be reverted eventually.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review Ready for a maintainer to consider for merging and removed S-Needs-Review labels Apr 2, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Apr 2, 2025
Merged via the queue into bevyengine:main with commit 5793a8c Apr 2, 2025
10 checks passed
@doup doup deleted the revert-relative-colors branch April 2, 2025 07:01
@doup doup mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

Assignees
No one assigned
Labels
C-Bug A problem with the code that runs the site C-Webdev S-Ready-For-Final-Review Ready for a maintainer to consider for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset title unreadable on light background Remove unquote calls from SASS files
4 participants
@doup @kristoff3r @bushrat011899 @alice-i-cecile