Skip to content

Auto rejoin - #1152

Open
ZainMGit wants to merge 4 commits into
beyond-all-reason:masterfrom
ZainMGit:auto-rejoinand
Open

Auto rejoin #1152
ZainMGit wants to merge 4 commits into
beyond-all-reason:masterfrom
ZainMGit:auto-rejoinand

Conversation

@ZainMGit

@ZainMGit ZainMGit commented Mar 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #1150

Auto rejoin only prompts if it has been <4 hours since battle join.

Creates rejoinBattleTimestamp at the same time which rejoinBattleID is created. if the timestamp is >4 hours then the rejoin prompt does not display.

4 hours is probably the maximum I'd see a match going but value can be adjusted.

@AntlerForce

AntlerForce commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

When we quit the game rather than crash, rejoinBattleID is set to nil here, and we should probably do the same to rejoinBattleTimestamp

@AntlerForce

Copy link
Copy Markdown
Collaborator

While testing this PR I am no longer able to able to get the Rejoin popup to appear.

I am testing by opening 2x copies of chobby, one from launcher, the other from debug launcher. With myself and my dev smurf in a multiplayer game, I am sending a SIGKILL from my system monitor to BAR and then launching the game again.

This triggers the rejoin popup on Alpha, but I could not get it to work with these changes.

@RogShotz

RogShotz commented May 17, 2026

Copy link
Copy Markdown
Contributor

Oh hey I commented on 1150. I think that reminding the player that they can reconnect from a crash is a better solution than no display. I kind of half assed my rejoin button to remind them that they just full left the game after the crash, but, after 4 hours changing the text to be "You previously crashed, remember that you can always rejoin!" might be better. Just my thoughts :)

It also might be easier to implement js saying ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto rejoin should not attempt to reconnect to battles older than 1-2 hours or so

3 participants