Add windows OS alerts (!ring, battle start/end) - #1247
Open
tetrisface wants to merge 2 commits into
Open
Conversation
Toast + icon flashing happens when: * Ring: Getting `!ring`ed. Always happens from Chobby perspective. * Game start/end: When queueing or being a player and the game starts/ends * No engine window (spring/recoil) is focused * Having each respective effect enabled which is default on The api_notifications_handler was dormant/dead. it previously acted at vote starts also. I think it's reasonable to try to limit alerts to the minimal defensible cases above. Mechanism: * Chobby sends Alert command over the existing bridge * Foreground check and flash toggle is done in powershell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I understand the launcher must be rebuilt and released for this chobby change to be usable. It worked with the built release from my fork though.
Only implemented for and tested on windows.
Toast + icon flashing happens when:
!ringedThe api_notifications_handler was dormant/dead. It previously acted at vote starts also. I think it's reasonable to try to limit alerts to the minimal defensible cases above.
Mechanism:
NotificationSkarminspelning.2026-08-22.112016-00.00.26.036-00.00.32.241.mp4
Skarminspelning.2026-08-22.112832-00.00.00.000-00.00.18.539-00.00.09.741-00.00.14.223.mp4
Also added a grouped and sorted section for notifications:

before
after

Test
Tested the indentation down to 1400 width resolution. Then it starts to break. But others break before that.
Alert logic tested with this notification widget that rings every 10 seconds:
Details
also tested with built release https://github.com/tetrisface/BYAR-Chobby/releases
AI Disclosure
All code produced as well as some code tested by Claude Fable. Edited, read and expected paths tested by me.