Add battle list filter for chev/rating restrictions - #1248
Open
SkyFire512 wants to merge 1 commit into
Open
Conversation
Adds a "Chev/Rating" toggle to the battle list filter row that parses server-appended "Min/Max chev" and "Min/Max rating"/"Rating: A-B" tags out of a battle's title and hides battles the local player doesn't qualify for, using the player's own chev (userInfo.level) and OpenSkill rating (WG.UserHandler.GetSnapshotSkillValue). AI usage: implemented with Claude Code, iteratively directed and verified against the running lobby (including UI layout adjustments based on screenshots of the actual filter row).
|
my pr in review for the last month does the same thing haha great minds thinkalike |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Chev/Rating" toggle to the battle list filter row that parses server-appended "Min/Max chev" and "Min/Max rating"/"Rating: A-B" tags out of a battle's title and hides battles the local player doesn't qualify for, using the player's own chev (userInfo.level) and OpenSkill rating (WG.UserHandler.GetSnapshotSkillValue).
AI usage: implemented with Claude Code, model Fable 5. All code written by AI, read and reviewed by me. Code has been tested manually against the running lobby, confirmed working correctly, attached screenshots below.