Fix gadget method errors in atmosphere configs - #4653
Merged
WatchTheFort merged 1 commit intoMar 31, 2025
Merged
Conversation
WatchTheFort
approved these changes
Mar 31, 2025
mr-maxo-PDG
pushed a commit
to mr-maxo-PDG/Beyond-All-Reason
that referenced
this pull request
Jul 15, 2025
Suppress more `duplicate-set-field` complaints from LLS using the same method established in beyond-all-reason#4608. This s a strict find+replace for `function gadget:GameFrame` in `./luarules/configs/Atmosphereconfigs`, removing one instance of the warning per file. These were not addressed in the first pass because I did a find and replace against `GetInfo` which these gagets do not use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Suppress more
duplicate-set-fieldcomplaints from LLS using the same method established in #4608.This s a strict find+replace for
function gadget:GameFramein./luarules/configs/Atmosphereconfigs, removing one instance of the warning per file.These were not addressed in the first pass because I did a find and replace against
GetInfowhich these gagets do not use.Test steps
n/a - only IDE facing changes.