Skip to content

Pr test runner - #5796

Closed
NortySpock wants to merge 19 commits into
beyond-all-reason:masterfrom
NortySpock:pr-test-runner
Closed

Pr test runner#5796
NortySpock wants to merge 19 commits into
beyond-all-reason:masterfrom
NortySpock:pr-test-runner

Conversation

@NortySpock

@NortySpock NortySpock commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

Work done

Current noted test output:

bar-1  | levelHeightMap in endTest isfunction
bar-1  | autoHeightMap in endTest isboolean
bar-1  | levelHeightMap directCall<function>
bar-1  | autoHeightMap is :true
bar-1  | levelHeightMap at level:nil
bar-1  | levelHeightMap value prevLevel:nil
bar-1  | levelHeightMap value currentLevel:0
bar-1  | [t=00:00:31.850611][f=0000037] [Test Runner] FAIL: cmd_stop_selfd/test_cmd_stop_selfd.lua [3 frames] [100 ms] | [string "common/testing/test_extra_utils.lua"]:64: attempt to call a nil value


I'm trying to find the " : attempt to call a nil value" call.

https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5796/files#diff-53face12c5764ed57e08651aed4a5ff6a812520b92bbfd46760b99560faa360fL39 shows that we're calling levelHeightMap with nil, ok....

In levelHeightMap, we catch if level == nil and set it to 10...

https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5796/files#diff-53face12c5764ed57e08651aed4a5ff6a812520b92bbfd46760b99560faa360fR15

So... is perhaps the issue actually that levelHeightMap()'s prevLevel is nil (set by currentLevel...) ?

Test steps

  • Write the steps needed to test out the changes. Include the expected result.

Test run: sudo docker compose -f tools/headless_testing/docker-compose.yml up

@NortySpock

Copy link
Copy Markdown
Contributor Author

I have gotten stumped on this, many tests are failing with a nil function call near levelHeightMap in endTest, I think

The LLM has lead me down a blind path while debugging the test so I'm having to actually read documentation and learn Lua, which takes longer ;) (mostly sarcastic there)

Pausing on this until I regain mana to fight this again.

https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5796/files#diff-53face12c5764ed57e08651aed4a5ff6a812520b92bbfd46760b99560faa360fR13

@NortySpock NortySpock closed this Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants