Pr test runner - #5796
Closed
NortySpock wants to merge 19 commits into
Closed
Conversation
NortySpock
force-pushed
the
pr-test-runner
branch
from
September 10, 2025 02:49
0495538 to
d461026
Compare
Contributor
Author
|
I have gotten stumped on this, many tests are failing with a nil function call near levelHeightMap in endTest, I think The LLM has lead me down a blind path while debugging the test so I'm having to actually read documentation and learn Lua, which takes longer ;) (mostly sarcastic there) Pausing on this until I regain mana to fight this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Current noted test output:
I'm trying to find the " : attempt to call a nil value" call.
https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5796/files#diff-53face12c5764ed57e08651aed4a5ff6a812520b92bbfd46760b99560faa360fL39 shows that we're calling levelHeightMap with nil, ok....
In levelHeightMap, we catch if level == nil and set it to 10...
https://github.com/beyond-all-reason/Beyond-All-Reason/pull/5796/files#diff-53face12c5764ed57e08651aed4a5ff6a812520b92bbfd46760b99560faa360fR15
So... is perhaps the issue actually that levelHeightMap()'s prevLevel is nil (set by currentLevel...) ?
Test steps
Test run:
sudo docker compose -f tools/headless_testing/docker-compose.yml up