Skip to content

sharing 6/7: Sharing Tab UI - #8064

Closed
keithharvey wants to merge 1 commit into
sharing/03-tech-keystonefrom
sharing/04-sharing-tab-ui
Closed

sharing 6/7: Sharing Tab UI#8064
keithharvey wants to merge 1 commit into
sharing/03-tech-keystonefrom
sharing/04-sharing-tab-ui

Conversation

@keithharvey

@keithharvey keithharvey commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

📚 The sharing stack — review bottom-up

Note

Part of native stack #8411 (feature tracking: #8412). Merges bottom-up through the GitHub stacked-PR UI once the type-migration stack (#8398) is in.

Each PR is file-partitioned: every file appears in exactly one PR in its final sharing_tab form, so each PR's diff is byte-identical to that branch. Regenerated deterministically by just bar::sharing-split.

Summary (LLM-generated, claude-opus-4-6)

Wires the sharing policy system into the unsynced UI layer: the advanced players list, top bar, selected-units shader, chat widget, team stats, and unit-share command all now read PolicyResult from the TeamTransfer module instead of using raw Spring.ShareResources calls and a flat sharingTax constant. Share buttons render enabled/disabled per-resource and per-unit PolicyResult fields (canShare, amountSendable), tooltips are generated by TooltipText helpers with full tech-progression and tax-rate context, and hovering a player row highlights invalid units in red via a new g_invalid flag in the DrawPrimitiveAtUnit shader pipeline. A new SharePolicyChanged widget call-in (registered in barwidgets.lua) triggers policy repack and validation invalidation so the UI stays consistent when policies change mid-game (e.g. on tech-up). Column-module definitions are extracted from gui_advplayerslist.lua into a gui_advplayerslist_modules.lua factory, and i18n strings are expanded into base/tech variants covering disabled, taxed, invalid, buildDelay, and stunDelay states.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

18 tests  ±0   10 ✅ ±0   20s ⏱️ ±0s
 1 suites ±0    8 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit bbb6a7c. ± Comparison against base commit f2c35ea.

♻️ This comment has been updated with latest results.

@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 7911463 to 41cb9cf Compare June 22, 2026 08:26
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 41cb9cf to b05ed42 Compare June 22, 2026 18:03
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from b05ed42 to 04252b9 Compare June 22, 2026 19:06
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch 2 times, most recently from daa0b5b to 6b37fb4 Compare June 25, 2026 21:37
@keithharvey keithharvey changed the title sharing 4/4: Sharing Tab UI sharing 4/5: Sharing Tab UI Jun 25, 2026
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 6b37fb4 to b58d6eb Compare June 25, 2026 22:26
@keithharvey keithharvey changed the title sharing 4/5: Sharing Tab UI sharing 5/6: Sharing Tab UI Jun 28, 2026
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from b58d6eb to f22459c Compare June 28, 2026 06:51
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch 2 times, most recently from 9e8fe32 to aca03b5 Compare June 28, 2026 07:28
@keithharvey keithharvey changed the title sharing 5/6: Sharing Tab UI sharing 6/7: Sharing Tab UI Jun 28, 2026
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from aca03b5 to 5ec9c9b Compare June 28, 2026 09:02
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from ce6c3d7 to 116f6a2 Compare July 10, 2026 10:19
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 116f6a2 to 4e1afac Compare July 10, 2026 10:44
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 4e1afac to cfbbc6a Compare July 15, 2026 07:34
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from cfbbc6a to 5ddf04e Compare July 15, 2026 20:06
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 5ddf04e to 9b37bc7 Compare July 15, 2026 20:27
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 9b37bc7 to 67948fc Compare July 15, 2026 20:37
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 67948fc to f170fa5 Compare July 15, 2026 22:17
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from f170fa5 to 2b37362 Compare July 16, 2026 03:11
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 2b37362 to 6c0061d Compare July 16, 2026 05:08
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 6c0061d to 80dde01 Compare July 16, 2026 10:53
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from 80dde01 to eb329b5 Compare July 16, 2026 12:06
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from eb329b5 to d22b57a Compare July 16, 2026 19:28
@keithharvey
keithharvey force-pushed the sharing/04-sharing-tab-ui branch from d22b57a to 15be988 Compare July 17, 2026 07:41
@keithharvey

Copy link
Copy Markdown
Collaborator Author

Superseded by the modules stack: sharing now ships as one de-noised PR — #8463 (modules — multiplayer 2/2: sharing v2), tracked in #8412. Closing this chain; the branch stays for reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant