sharing 6/7: Sharing Tab UI - #8064
Closed
keithharvey wants to merge 1 commit into
Closed
Conversation
Contributor
This was referenced Jun 22, 2026
Closed
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
June 22, 2026 08:26
7911463 to
41cb9cf
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
June 22, 2026 18:03
41cb9cf to
b05ed42
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
June 22, 2026 19:06
b05ed42 to
04252b9
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
2 times, most recently
from
June 25, 2026 21:37
daa0b5b to
6b37fb4
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
June 25, 2026 22:26
6b37fb4 to
b58d6eb
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
June 28, 2026 06:51
b58d6eb to
f22459c
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
2 times, most recently
from
June 28, 2026 07:28
9e8fe32 to
aca03b5
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
June 28, 2026 09:02
aca03b5 to
5ec9c9b
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 10, 2026 10:19
ce6c3d7 to
116f6a2
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 10, 2026 10:44
116f6a2 to
4e1afac
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 15, 2026 07:34
4e1afac to
cfbbc6a
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 15, 2026 20:06
cfbbc6a to
5ddf04e
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 15, 2026 20:27
5ddf04e to
9b37bc7
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 15, 2026 20:37
9b37bc7 to
67948fc
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 15, 2026 22:17
67948fc to
f170fa5
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 16, 2026 03:11
f170fa5 to
2b37362
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 16, 2026 05:08
2b37362 to
6c0061d
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 16, 2026 10:53
6c0061d to
80dde01
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 16, 2026 12:06
80dde01 to
eb329b5
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 16, 2026 19:28
eb329b5 to
d22b57a
Compare
keithharvey
force-pushed
the
sharing/04-sharing-tab-ui
branch
from
July 17, 2026 07:41
d22b57a to
15be988
Compare
This was referenced Jul 22, 2026
Closed
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 The sharing stack — review bottom-up
Note
Part of native stack #8411 (feature tracking: #8412). Merges bottom-up through the GitHub stacked-PR UI once the type-migration stack (#8398) is in.
Each PR is file-partitioned: every file appears in exactly one PR in its final
sharing_tabform, so each PR's diff is byte-identical to that branch. Regenerated deterministically byjust bar::sharing-split.Summary (LLM-generated, claude-opus-4-6)
Wires the sharing policy system into the unsynced UI layer: the advanced players list, top bar, selected-units shader, chat widget, team stats, and unit-share command all now read
PolicyResultfrom theTeamTransfermodule instead of using rawSpring.ShareResourcescalls and a flatsharingTaxconstant. Share buttons render enabled/disabled per-resource and per-unitPolicyResultfields (canShare,amountSendable), tooltips are generated byTooltipTexthelpers with full tech-progression and tax-rate context, and hovering a player row highlights invalid units in red via a newg_invalidflag in theDrawPrimitiveAtUnitshader pipeline. A newSharePolicyChangedwidget call-in (registered inbarwidgets.lua) triggers policy repack and validation invalidation so the UI stays consistent when policies change mid-game (e.g. on tech-up). Column-module definitions are extracted fromgui_advplayerslist.luainto agui_advplayerslist_modules.luafactory, and i18n strings are expanded intobase/techvariants covering disabled, taxed, invalid, buildDelay, and stunDelay states.