Skip to content

fix issue where ships could get incorrect pathmap blocking zones - #3132

Open
lostsquirrel1 wants to merge 1 commit into
masterfrom
BAR-106-fix_ships_stuck_on_wrecks
Open

fix issue where ships could get incorrect pathmap blocking zones #3132
lostsquirrel1 wants to merge 1 commit into
masterfrom
BAR-106-fix_ships_stuck_on_wrecks

Conversation

@lostsquirrel1

@lostsquirrel1 lostsquirrel1 commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

… with underwater structures near coast lines. Well, anything that floats in the water, not just ships.

@sprunk

sprunk commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

I think isSubmersible was meant for units that can fully submerge, i.e. can go low enough that their top is underwater. But things that float on water will never do that:

// can this unit completely submerge in water?

The meaning may have changed along the way so this may still be the correct fix despite that (I can't really tell) but in that case it would be good to adjust that comment, or perhaps rename the var for the new meaning (blockedBySeafloorObjects or whatever).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants