Skip to content

Let unbind target one action argument variant - #3145

Draft
burnhamrobertp wants to merge 2 commits into
beyond-all-reason:masterfrom
burnhamrobertp:bug/unbind-action-arguments
Draft

Let unbind target one action argument variant#3145
burnhamrobertp wants to merge 2 commits into
beyond-all-reason:masterfrom
burnhamrobertp:bug/unbind-action-arguments

Conversation

@burnhamrobertp

@burnhamrobertp burnhamrobertp commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes #3140. unbind compared the action name against the whole "name plus arguments" string, so unbind a firestate 2 matched nothing while unbind a firestate removed every variant on the key. It now parses what you typed through Action, like Bind does when storing, and compares name and arguments separately - so after bind sc_a firestate 2, unbind sc_a firestate deliberately removes nothing.

unbindaction keeps sweeping on a bare name, since it takes no keyset and so isn't the inverse of a bind. BAR's 60% presets depend on that. Naming arguments narrows it now, which also needed the dispatch fixed - it was forwarding the action and dropping the arguments.

Wants #3136 first, which adds a chain-aware overload to UnBind that the argument check has to be carried into.

Round-tripped headless from zero to twelve arguments and a 239 character selectkey argument, with near misses correctly left alone.

Used Claude to help investigate and write this.

@burnhamrobertp

Copy link
Copy Markdown
Contributor Author

(is ready for merge, I kept it as a draft just to keep it from accidentally going in before 3136)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/unbind inconsistent behavior with extra parameters after action

2 participants