DemoTool: fix the build after the alternate replay extension change - #3161
Open
tomjn wants to merge 1 commit into
Open
DemoTool: fix the build after the alternate replay extension change#3161tomjn wants to merge 1 commit into
tomjn wants to merge 1 commit into
Conversation
DemoReader.cpp calls IsDemoExtension unconditionally but included its header inside #ifndef TOOLS, and demotool never compiled DemoFileExtension.cpp. The tools build has been broken on every platform since alternate replay extensions landed. demotool is EXCLUDE_FROM_ALL so CI does not catch it. IsDemoExtension already had a TOOLS branch, so the intent was there. Only the config-backed extension list needs excluding, since tools do not link the config subsystem.
sprunk
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DemoReader.cpp calls IsDemoExtension unconditionally but includes its header inside #ifndef TOOLS, and demotool never compiled DemoFileExtension.cpp. The tools build has been broken on every platform since alternate replay extensions landed in #2975. demotool is EXCLUDE_FROM_ALL, so CI does not build it.
IsDemoExtension already had a TOOLS branch, so the intent was there. Only the config-backed extension list needs excluding, since tools do not link the config subsystem.