Skip to content

Conversation

@galbus
Copy link
Contributor

@galbus galbus commented Jul 11, 2025

No description provided.

@galbus galbus self-assigned this Jul 11, 2025
@galbus galbus added php Pull requests that update Php code javascript Pull requests that update Javascript code labels Jul 11, 2025
@linear
Copy link

linear bot commented Jul 11, 2025

@galbus galbus requested a review from Copilot September 12, 2025 09:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces "Magic Embed" (client-side integration) as a new integration method for the BeyondWords WordPress plugin, allowing content to be generated on-demand when pages are visited rather than via REST API calls. The changes refactor the player architecture to use inline script tags instead of enqueued scripts and implement a renderer-based approach for different player types.

  • Adds new client-side integration method alongside the existing REST API method
  • Refactors player system to use inline script tags with a renderer pattern (Javascript and AMP)
  • Updates test infrastructure to work with new player implementation

Reviewed Changes

Copilot reviewed 67 out of 68 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/phpunit/Settings/Fields/PlayerUI/PlayerUITest.php Updates PlayerUI constants to use class constants instead of string literals
tests/phpunit/Core/UninstallerTest.php Adds cleanup for new integration method option and forces post deletion
tests/phpunit/Core/PlayerTest.php Major refactor from legacy player tests to new renderer-based player tests
tests/phpunit/Core/Player/Renderer/JavascriptTest.php New tests for JavaScript player renderer
tests/phpunit/Core/Player/Renderer/AmpTest.php New tests for AMP player renderer
tests/phpunit/Core/Player/ConfigBuilderTest.php New tests for SDK parameter configuration builder
tests/phpunit/Core/CoreUtilsTest.php Adds integration method to post meta keys list
tests/phpunit/Core/CoreTest.php Updates for Magic Embed support and new audio generation logic
tests/cypress/support/commands.js Updates player detection to work with new inline script approach
Multiple cypress test files Updates to use new player detection commands
Source files Implements Magic Embed integration, new player architecture, and related infrastructure
Comments suppressed due to low confidence (1)

tests/phpunit/Core/Player/Renderer/AmpTest.php:1

  • The test is calling static methods on 'Amp' class but the test class itself is named 'Amp', creating a naming collision. The test class should be properly named 'AmpTest' and call the actual renderer class methods.
<?php

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@galbus galbus merged commit 6ba7f27 into s-7155-plugin-v600 Sep 12, 2025
@galbus galbus deleted the s-7095-scope-out-integrating-the-magic-embed-script-into-wordpress branch September 12, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants