feature/gc-filesys-check#23
Merged
bgunnar5 merged 7 commits intoOct 22, 2025
Merged
Conversation
jwhite242
reviewed
Oct 20, 2025
jwhite242
left a comment
jwhite242
left a comment
There was a problem hiding this comment.
Thanks for adding functionality to detect this. Few more general thoughts and a question that I think I missed in the code:
- Would be good to have some non-mocked tests in here to verify some of the functionality
- Can you explain more how the machinery actually detects the special '/' root for ignoring it in other path searches since they all start with '/'? Is it the is_mount funcs from the stdlib that know the difference between it and another mounted system?
Owner
Author
|
@jwhite242 it's the |
bgunnar5
merged commit 62d2e59
into
feature/db-garbage-collection
40 of 41 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checks for file system mounts when we're validating the existence of workspace paths. This will help keep database run entries from being deleted when the file system for their workspaces isn't accessible from the current machine.