Add constrainSize method + replace !=0 with >0 checks in UIView+Layout.swift#36
Open
zakbarlow1995 wants to merge 5 commits intobhlvoong:masterfrom
Open
Add constrainSize method + replace !=0 with >0 checks in UIView+Layout.swift#36zakbarlow1995 wants to merge 5 commits intobhlvoong:masterfrom
zakbarlow1995 wants to merge 5 commits intobhlvoong:masterfrom
Conversation
added 5 commits
July 17, 2019 09:14
…ges to upstream/master
…ks) and removed moot translatesAutoresizingMaskIntoConstraints = false statements from UIView+Layout.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
constrainSize(_ size: CGSize) -> AnchoredConstraintsmethod, replaced old !=0 checks with >0 for width/height constraints (matching new variadicanchormethod) & removed moottranslatesAutoresizingMaskIntoConstraints = falsesetting infillSuperview(SafeAreaLayoutGuide)methods (as followinganchorcall does this). Also removed unusedlet anchoredConstraints = AnchoredConstraints()declaration infillSuperview(SafeAreaLayoutGuide)methods.Tweaks to
constrainWidth/Heightensure that an invalid constant (i.e. one that is ≤0) does not alter view.