Fix changing a character in the middle of the text#42
Open
FabioBachi wants to merge 1 commit intobhrott:masterfrom
Open
Fix changing a character in the middle of the text#42FabioBachi wants to merge 1 commit intobhrott:masterfrom
FabioBachi wants to merge 1 commit intobhrott:masterfrom
Conversation
lucalves
reviewed
Nov 23, 2019
| @override | ||
| void set text(String newText) { | ||
| set text(String newText) { | ||
| print(newText); |
There was a problem hiding this comment.
I believe this print is unnecessary here.
|
Is the print statement the only problem here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#41