Skip to content

Added option to add video/text comments#470

Merged
vipinpaul merged 23 commits into
developmentfrom
Video_comments
May 29, 2026
Merged

Added option to add video/text comments#470
vipinpaul merged 23 commits into
developmentfrom
Video_comments

Conversation

@B3RN153

@B3RN153 B3RN153 commented May 5, 2026

Copy link
Copy Markdown
Collaborator
  • Add video comments in video mode.

  • Add multiple comments for each verse.

  • Add text comments for video

  • Add an icon for comments in the editor along with other which shows the number of comments.

  • Individually delete a video or note of a comment.

  • Rerecord and delete video comments.

  • Edit and delete comment notes.

  • Comments can be accessed from video navigation.

  • Mic default mute in video recorder.

  • Replacing is working fine for video

  • Comments remain after a usfm import

@B3RN153 B3RN153 self-assigned this May 5, 2026
@B3RN153 B3RN153 added enhancement New feature or request Video labels May 5, 2026
@B3RN153 B3RN153 linked an issue May 5, 2026 that may be closed by this pull request
@Roslin22

Roslin22 commented May 8, 2026

Copy link
Copy Markdown

Issues Identified

  1. When the user clicks the comments icon, the comments window opens. Currently, the user must click the Add Comment button again to add a new text or video comment. This extra step can be removed by directly showing the comment input options when the comments window opens.
  2. When more than 3 comments are added, the Add More Comment button is no longer visible immediately. The user must scroll down to access it.
  3. When verses are joined for a video, the associated video gets deleted, but the comments remain merged. If no videos are available, the related comments should also be removed.

Suggestion

  1. Instead of displaying the full video preview inside the comments window, show only a video indicator or thumbnail. This will reduce space usage and allow users to view more comments at the same time
image
  1. The comment details and verse number can be displayed below the username in the comments window, making it clearer and easier for users to understand.

@vipinpaul

Copy link
Copy Markdown
Collaborator

@B3RN153 do work on the 1st and 2nd, as discussed over the call.
@Roslin22 The third one is a feature. We don't want to delete the comments, as they might help the person to do the translation.

@B3RN153

B3RN153 commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

Issues Identified

  1. When the user clicks the comments icon, the comments window opens. Currently, the user must click the Add Comment button again to add a new text or video comment. This extra step can be removed by directly showing the comment input options when the comments window opens.
  2. When more than 3 comments are added, the Add More Comment button is no longer visible immediately. The user must scroll down to access it.
  3. When verses are joined for a video, the associated video gets deleted, but the comments remain merged. If no videos are available, the related comments should also be removed.

Suggestion

  1. Instead of displaying the full video preview inside the comments window, show only a video indicator or thumbnail. This will reduce space usage and allow users to view more comments at the same time
image 3. The comment details and verse number can be displayed below the username in the comments window, making it clearer and easier for users to understand.
  1. User need not click add more comments in the first time.
image
  1. The Add more comment is fixed and scroll down when clicked.
image
  1. Comment Verse moved below username.

@B3RN153
B3RN153 requested a review from vipinpaul May 8, 2026 11:39
@Roslin22

Copy link
Copy Markdown

Test Results

  1. User is able to add comments to videos in both text and video formats.
  2. User is able to add and delete both text and video comments, and the UI updates correctly.
  3. User is able to add multiple comments, and the UI reflects the changes properly.

Other Functionalities Tested

  1. User is able to record videos and record again after deleting previous recordings.
  2. User is able to record videos with multiple pause and resume actions.
  3. User is able to delete recordings, and the UI updates accordingly.
  4. User is able to join and disjoin verses, and the associated comments are also joined and disjoined correctly.
  5. User is able to import USFM books, and the existing videos are overwritten successfully.
  6. User is able to export a project, import it into another user account, and disjoin the verses successfully.
  7. Scope testing was completed for All, NT, OT, and Custom scopes, and all are working as expected.

Issues Identified

  1. While adding a new scope for a new project, the “For Info” link is not opening and displays a “Page Not Found” error message.
image
  1. When there are many comments, the “Add More Comments” button overlaps with the comments section.
image

@B3RN153
B3RN153 force-pushed the Video_comments branch 4 times, most recently from 4711e3f to 01aa179 Compare May 25, 2026 11:11
@Roslin22

Copy link
Copy Markdown

Test Results:

The old joined verse videos are still present in the video folder even after disjoining the verses and replacing the project.

 Steps to reproduce:

  1. Create a project
  2. Join the verses
  3. Export the project
  4. Import the exported project into another account
  5. Disjoin the verses
  6. Export the modified project
  7. Import the modified project into the first account and choose “Replace Project”
  8. Export the project again
  9. Check the video folder (old joined verses still present in the exported project)
     

@Roslin22

Copy link
Copy Markdown

Test Results

Previously reported issues have been resolved.

Functionalities Tested

  1. User is able to add comments to videos in both text and video formats.
  2. User is able to add and delete both text and video comments, and the UI updates correctly.
  3. User is able to add multiple comments, and the UI reflects the changes properly.
  4. User is able to record videos and re-record after deleting previous recordings.
  5. User is able to record videos with multiple pause and resume actions.
  6. User is able to delete recordings, and the UI updates accordingly.
  7. User is able to join and disjoin verses, and the associated comments are joined and disjoined correctly.
  8. When the user records comments while verses are joined, and later disjoins the verses, the joined verse comments are available in all the disjoined verses correctly.
  9. User is able to import USFM books, and the existing videos are overwritten successfully.
  10. User is able to export a project, import it into another user account, and disjoin the verses successfully.
  11. When the user imports a USFM file into the project, the videos are deleted, but the comments are imported successfully.
  12. Scope testing was completed for All, NT, OT, and Custom scopes, and all are working as expected.

@vipinpaul
vipinpaul merged commit 84c9bcb into development May 29, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Video

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature to add coments in video mode

3 participants