-
Notifications
You must be signed in to change notification settings - Fork 190
[ENH][BEP028] Specification update for BEP028 BIDS-Prov #2099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Ross Blair <[email protected]>
|
Hi @rwblair, Most of the rules you propose are related to the validation of the provenance metadata itself. I believe that these could be brought later to the validator / schema ? I agree that this is easier to validate once the metadata is aggregated; I understood you found the python code to do that. I also plan to write python code for defects detection in a provenance graph (e.g.: isolated nodes, undefined objects, etc.) which could later help for validation. About Ids, we need to be more precise in the specification about that. The idea is that we want to have BIDS URIs as much as possible, also because it's more human readable. But at the same time, we want to ensure uniqueness of the Id outside the dataset, which is not the case for BIDS URIs as currently defined. Does it make sense to you ? |
…nfo rather than an important note
@rwblair thanks a lot for this detailed overview. I second @bclenet's comment in that we were thinking of a much lighter validation using the BIDS schema (mainly making sure that the newly created files had a proper naming and that the keys inside the metadata files corresponded to what is in the spec). I was hoping we could focus on this first before we open the BEP for community review. @rwblair @effigies: Could we plan a quick meeting to identify the remaining steps we need to follow in order to update the schema for BIDS-Prov (BEP028)? So we can have a clearer plan of when we'll be able to open for community review. Thank you! |
[ENH] Update to BIDS-Prov specification pull request
This is a work in progress PR proposing a specification update for BEP028 BIDS-Prov.
Todo lists
Blocking points
prov/[prov-<label>]BEP028_BIDSprov#169GeneratedByBEP028_BIDSprov#170Associated BIDS examples