fixed loading of 0,0,0 block for 8bit data #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @tpietzsch,
bad news, I've found a bug: rendering of 8bit multi resolution sometimes shows
black boxes. It occurs randomly, not every time and most of
the time this block is at the zero axis boundary or close to the origin of coordinates.
So to reproduce an error, I've made an example Debug8bitMultiRes.java,
where 8bit is loaded in green and the same 16bit data is loaded in red.
This is how it looks like (without the fix):
20250527_texture_load_BVV.mp4
The reason for that being (after reading the code) that the 0,0,0 block is loaded
in a special way, because of
texSubImage3D
bug.Now, the good news: the easy correction of its loading in
TextureCache
seems to fix it (as submitted).Let me know what you think.
Cheers,
Eugene