Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate Web Types for the package based on current documentation #3071

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

piotrtomiak
Copy link
Contributor

Description

This change adds a build step, which will regenerate web-types based on existing documentation. Special support for htmx-on: has been added as well.

untitled8-1 – sdsad html 2024-12-12 12-28-54

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@piotrtomiak
Copy link
Contributor Author

It would be great if you can provide an SVG 32x32 with the HTMX icon. I could then set the icon for all of HTMX attributes, css classes and events.

@Telroshan Telroshan added devops Changes to the repository structure or project management documentation Improvements or additions to documentation labels Dec 13, 2024
@1cg
Copy link
Contributor

1cg commented Feb 25, 2025

Heya @piotrtomiak thank you very much for this contribution. I am not really qualified to review it, but I will ask if anyone on the core team feels like they can. If not, I will pluck up the courage to look at it. :)

There is a (dark mode) svg icon for htmx here:

https://bestofjs.org/logos/htmx.dark.svg

@piotrtomiak
Copy link
Contributor Author

piotrtomiak commented Feb 28, 2025

@1cg - thanks! The code doesn't touch any of the HTMX code, it just adds a build script to generate the web-types file based on the available documentation, so I guess it's a new stuff for anyone reviewing ;) I'll update the PR with the icon soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Changes to the repository structure or project management documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants