Support for Specification Extensions #11 for v3.2.2 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like tests fail because of aeson-2 🤔 Also, would it be possible to hide empty |
|
oh dear...I didn't think to check Yes, I think hiding empty extensions makes a lot of sense. This was quite a quick and dirty job. I'll see what I can do after work. |
|
Well, it hides the empty extensions now; I am unsure about |
|
@maksbotan @PPKFS I added support for aeson < 2 and >= 2 to this patch and opened #43. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just updates the work of @blackheaven and @mageshb to:
a) remove the excess formatting changes
b) work with the most recent version of openapi3.
The tests all pass, but there could be some edge cases I've not covered where the versions have differed in the mean time.